Skip to content

Conversation

@pcmoritz
Copy link
Contributor

This is currently based off #3848

@kszucs kszucs force-pushed the master branch 2 times, most recently from ed180da to 85fe336 Compare July 22, 2019 19:29
@emkornfield
Copy link
Contributor

@pitrou I think you have a similar PR for python? Can this be closed?

@pitrou
Copy link
Member

pitrou commented Aug 6, 2019

@emkornfield I don't think so. But perhaps something similar was merged recently?

@codecov-io
Copy link

Codecov Report

Merging #3858 into master will increase coverage by 0.39%.
The diff coverage is 83.02%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3858      +/-   ##
==========================================
+ Coverage   87.46%   87.85%   +0.39%     
==========================================
  Files         994      625     -369     
  Lines      140389    67612   -72777     
  Branches     1418     1252     -166     
==========================================
- Hits       122788    59400   -63388     
+ Misses      17239     8095    -9144     
+ Partials      362      117     -245
Impacted Files Coverage Δ
cpp/src/arrow/type_traits.h 91.8% <ø> (+7.18%) ⬆️
cpp/src/arrow/visitor.h 66.66% <ø> (+16.66%) ⬆️
cpp/src/arrow/visitor_inline.h 93.67% <ø> (+4.88%) ⬆️
cpp/src/arrow/pretty_print.cc 80.29% <ø> (-3.05%) ⬇️
cpp/src/gandiva/expression_registry.cc 81.92% <ø> (-8.68%) ⬇️
cpp/src/arrow/array/builder_union.cc 2.5% <0%> (-89.81%) ⬇️
cpp/src/arrow/array/builder_union.h 0% <0%> (-80.96%) ⬇️
cpp/src/arrow/visitor.cc 0% <0%> (ø) ⬆️
cpp/src/parquet/arrow/writer.cc 92.52% <0%> (-4.19%) ⬇️
cpp/src/arrow/array/builder_nested.h 100% <100%> (ø) ⬆️
... and 891 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85fe336...49faafb. Read the comment docs.

@emkornfield
Copy link
Contributor

This looks like it has gotten pretty stale, I'm going to close it, please @pcmoritz please reopen when you have time to work on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants