Skip to content

GH-38648: [Java] Regenerate Flatbuffers#38650

Merged
lidavidm merged 1 commit intoapache:mainfrom
danepitkin:danepitkin/java-flatbuffer-regen
Nov 9, 2023
Merged

GH-38648: [Java] Regenerate Flatbuffers#38650
lidavidm merged 1 commit intoapache:mainfrom
danepitkin:danepitkin/java-flatbuffer-regen

Conversation

@danepitkin
Copy link
Copy Markdown
Member

@danepitkin danepitkin commented Nov 9, 2023

Rationale for this change

Regenerate the Flatbuffers to include new formats. Flatbuffers are always forwards/backwards compatible as long as the code is generated from the same flatc compiler version.

What changes are included in this PR?

  • Flatbuffers regenerated with flatc v1.12.0

Are these changes tested?

Yes, via unit tests.

Are there any user-facing changes?

Yes, RecordBatch.java was modified.

@danepitkin danepitkin requested a review from lidavidm as a code owner November 9, 2023 15:07
@danepitkin
Copy link
Copy Markdown
Member Author

@github-actions crossbow submit java

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Nov 9, 2023

⚠️ GitHub issue #38648 has been automatically assigned in GitHub to PR creator.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Nov 9, 2023

Revision: dd33346

Submitted crossbow builds: ursacomputing/crossbow @ actions-286578af8f

Task Status
java-jars Github Actions
verify-rc-source-java-linux-almalinux-8-amd64 Github Actions
verify-rc-source-java-linux-conda-latest-amd64 Github Actions
verify-rc-source-java-linux-ubuntu-20.04-amd64 Github Actions
verify-rc-source-java-linux-ubuntu-22.04-amd64 Github Actions
verify-rc-source-java-macos-amd64 Github Actions

@github-actions github-actions Bot added awaiting merge Awaiting merge and removed awaiting review Awaiting review labels Nov 9, 2023
@danepitkin
Copy link
Copy Markdown
Member Author

The Java Jar failures on Mac exists on main. Here is the first failure from 3 days ago: https://github.com/ursacomputing/crossbow/actions/runs/6795651621/job/18474132638

I'll file a separate issue for this.

@lidavidm lidavidm merged commit 1f71014 into apache:main Nov 9, 2023
@lidavidm lidavidm removed the awaiting merge Awaiting merge label Nov 9, 2023
@felipecrv
Copy link
Copy Markdown
Contributor

FYI, for C++/Go, we are using flatc version 23.5.26 (the latest tag) since #38192

@conbench-apache-arrow
Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 1f71014.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them.

loicalleyne pushed a commit to loicalleyne/arrow that referenced this pull request Nov 13, 2023
### Rationale for this change

Regenerate the Flatbuffers to include new formats. Flatbuffers are always forwards/backwards compatible as long as the code is generated from the same `flatc` compiler version.

### What changes are included in this PR?

* Flatbuffers regenerated with `flatc` v1.12.0

### Are these changes tested?

Yes, via unit tests.

### Are there any user-facing changes?

Yes, RecordBatch.java was modified.
* Closes: apache#38648

Authored-by: Dane Pitkin <dane@voltrondata.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
dgreiss pushed a commit to dgreiss/arrow that referenced this pull request Feb 19, 2024
### Rationale for this change

Regenerate the Flatbuffers to include new formats. Flatbuffers are always forwards/backwards compatible as long as the code is generated from the same `flatc` compiler version.

### What changes are included in this PR?

* Flatbuffers regenerated with `flatc` v1.12.0

### Are these changes tested?

Yes, via unit tests.

### Are there any user-facing changes?

Yes, RecordBatch.java was modified.
* Closes: apache#38648

Authored-by: Dane Pitkin <dane@voltrondata.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
pribor pushed a commit to GlobalWebIndex/arrow that referenced this pull request Oct 24, 2025
### Rationale for this change

Regenerate the Flatbuffers to include new formats. Flatbuffers are always forwards/backwards compatible as long as the code is generated from the same `flatc` compiler version.

### What changes are included in this PR?

* Flatbuffers regenerated with `flatc` v1.12.0

### Are these changes tested?

Yes, via unit tests.

### Are there any user-facing changes?

Yes, RecordBatch.java was modified.
* Closes: apache#38648

Authored-by: Dane Pitkin <dane@voltrondata.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Java] Regenerate Flatbuffers to include new formats released in Arrow v14

3 participants