ARROW-3364: [Docs] Add docker-compose integration documentation #3882
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kszucs
reviewed
Mar 13, 2019
kszucs
reviewed
Mar 13, 2019
kszucs
reviewed
Mar 13, 2019
Member
kszucs
left a comment
kszucs
left a comment
There was a problem hiding this comment.
Just a few nits. Thanks for doing this @fsaintjacques!
Contributor
Author
|
Build fails due to conda timeout. |
fsaintjacques
force-pushed
the
ARROW-3364-docker-compose-documentation
branch
from
75884b2 to
595d50a
Compare
wesm
reviewed
Mar 14, 2019
Makefile.docker
Outdated
| $(DC) build $(subst build-,,$@) | ||
|
|
||
| # The following targets create the dependencies of the form `build-X: build-Y` | ||
| $(addprefix build-,$(DEPENDS_ON_CPP)): build-cpp |
Member
There was a problem hiding this comment.
This is pretty fancy. While the other way is more verbose, it is a bit more readable. Thoughts?
Contributor
Author
There was a problem hiding this comment.
I simplified it to make stuff more explicit and less string manipulations.
Codecov Report
@@ Coverage Diff @@
## master #3882 +/- ##
==========================================
+ Coverage 87.78% 88.63% +0.85%
==========================================
Files 727 592 -135
Lines 87795 78419 -9376
Branches 1252 0 -1252
==========================================
- Hits 77069 69508 -7561
+ Misses 10608 8911 -1697
+ Partials 118 0 -118
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.