-
Notifications
You must be signed in to change notification settings - Fork 4k
GH-39013: [Go][Integration] Support cABI import/export of StringView #39019
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
56f7134
5dd6ea5
9766f85
a276351
b89bd69
8e80f5a
c656338
0c33184
33a679f
44d8f73
8e4a09c
2505971
7005868
0678158
14fe8ec
12dd7ea
062dade
623c9f9
6f14220
6d3c69b
952001f
97edc75
03a12f9
b923766
e10341a
cb6a4ef
297f456
e3467e9
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -193,6 +193,8 @@ def _run_test_cases(self, | |
| ``case_runner`` ran against ``test_cases`` | ||
| """ | ||
| def case_wrapper(test_case): | ||
| if serial: | ||
| return case_runner(test_case) | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is this addition deliberate?
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes: printer.cork() was failing to dump output when the test segfaulted. In any case, corking the printer adds no value when we're running in serial. |
||
| with printer.cork(): | ||
| return case_runner(test_case) | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FTR, we don't need
OrderedDictanymore as regular dicts are now ordered by default.