GH-35560: [C++] Use Cast() instead of CastTo() for Scalar in test #39044
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
llama90
force-pushed
the
feature/remove-scalar-regacy
branch
from
393021d to
d5d26d1
Compare
github-actions
bot
added
awaiting merge
kou
changed the title
|
|
llama90
force-pushed
the
feature/remove-scalar-regacy
branch
from
fb31c68 to
a9a7d0d
Compare
Contributor
Author
|
Hello, @kou I resolved a conflict that arose due to a commit related to timestamp casting. |
bkietz
approved these changes
Dec 5, 2023
|
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 7ccf6fd. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them. |
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
…st (apache#39044) ### Rationale for this change Remove legacy code ### What changes are included in this PR? * Replace the legacy scalar `CastTo` implementation with the new cast compute kernel for supported types, without requiring additional casting logic for unsupported types. ### Are these changes tested? Yes. It is passed by existing test cases. ### Are there any user-facing changes? No. * Closes: apache#35560 Authored-by: Hyunseok Seo <hsseo0501@gmail.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Remove legacy code
What changes are included in this PR?
CastToimplementation with the new cast compute kernel for supported types, without requiring additional casting logic for unsupported types.Are these changes tested?
Yes. It is passed by existing test cases.
Are there any user-facing changes?
No.