GH-39050: [C++] Use Cast() instead of CastTo() for Timestamp Scalar in test #39060
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit c39a223. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them. |
kou
pushed a commit
that referenced
this pull request
Dec 14, 2023
…est (#39226) ### Rationale for this change Remove legacy code This is a sub-PR of the PR mentioned below. * #39060 ### What changes are included in this PR? * Replace the legacy scalar `CastTo` implementation for Timestamp Scalar in test. It was supposed to be resolved in the mentioned PR, but it was missed. ### Are these changes tested? Yes. It is passed by existing test cases. ### Are there any user-facing changes? No. Authored-by: Hyunseok Seo <hsseo0501@gmail.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
…alar in test (apache#39060) ### Rationale for this change Remove legacy code ### What changes are included in this PR? * Replace the legacy scalar CastTo implementation for Timestamp Scalar in test. The cast function already supports casting between different timestamp types. We just need to allow for the possibility of data loss by using `CastOptions::Unsafe()`. ### Are these changes tested? Yes. It is passed by existing test cases. ### Are there any user-facing changes? No. * Closes: apache#39050 Authored-by: Hyunseok Seo <hsseo0501@gmail.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
…est (apache#39226) ### Rationale for this change Remove legacy code This is a sub-PR of the PR mentioned below. * apache#39060 ### What changes are included in this PR? * Replace the legacy scalar `CastTo` implementation for Timestamp Scalar in test. It was supposed to be resolved in the mentioned PR, but it was missed. ### Are these changes tested? Yes. It is passed by existing test cases. ### Are there any user-facing changes? No. Authored-by: Hyunseok Seo <hsseo0501@gmail.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Remove legacy code
What changes are included in this PR?
CastOptions::Unsafe().Are these changes tested?
Yes. It is passed by existing test cases.
Are there any user-facing changes?
No.