Skip to content

GH-39333: [C++] Don't use "if constexpr" in lambda #39334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pitrou merged 2 commits into from
Dec 21, 2023
Merged

GH-39333: [C++] Don't use "if constexpr" in lambda #39334

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
47ed583
GH-39333: [C++] Don't use "if constexpr" in lambda
kou Dec 21, 2023
e2ee3d3
Apply simpler solution
pitrou Dec 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions cpp/src/arrow/array/array_nested.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,10 +287,8 @@ Result<std::shared_ptr<Array>> FlattenListViewArray(const ListViewArrayT& list_v
const auto* sizes = list_view_array.data()->template GetValues<offset_type>(2);

auto is_null_or_empty = [&](int64_t i) {
if constexpr (HasNulls) {
if (!bit_util::GetBit(validity, list_view_array_offset + i)) {
return true;
}
if (HasNulls && !bit_util::GetBit(validity, list_view_array_offset + i)) {
return true;
}
return sizes[i] == 0;
};
Expand Down