Skip to content

GH-39051: [C++] Use Cast() instead of CastTo() for List Scalar in test #39353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kou merged 16 commits into from
Jan 1, 2024
Merged

GH-39051: [C++] Use Cast() instead of CastTo() for List Scalar in test #39353

kou merged 16 commits into from
Jan 1, 2024

Conversation

@llama90
Copy link
Contributor

@llama90 llama90 commented Dec 22, 2023 •
edited by github-actions bot
Loading

Rationale for this change

Remove legacy code

What changes are included in this PR?

Replace the legacy scalar CastTo implementation for List Scalar in test.

Are these changes tested?

Yes. It is passed by existing test cases.

Are there any user-facing changes?

No.

@llama90 llama90 marked this pull request as draft December 22, 2023 13:18
@github-actions
Copy link

github-actions bot commented Dec 22, 2023

⚠️ GitHub issue #39051 has been automatically assigned in GitHub to PR creator.

@llama90 llama90 marked this pull request as ready for review December 23, 2023 14:55
kou
kou reviewed Dec 26, 2023
View reviewed changes
cpp/src/arrow/scalar_test.cc Outdated
Comment on lines 1107 to 1110
void CheckInvalidListCast(const ScalarType& scalar,
const std::shared_ptr<DataType>& to_type, const StatusCode code,
const std::string& expected_message) {
EXPECT_RAISES_WITH_CODE_AND_MESSAGE_THAT(StatusCode::Invalid,
::testing::HasSubstr(expected_message),
scalar.CastTo(to_type));
EXPECT_RAISES_WITH_CODE_AND_MESSAGE_THAT(code, ::testing::HasSubstr(expected_message),
Copy link
Member

@kou kou Dec 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's strange that CheckInvalidListCast() may not expect StatusCode::Invalid.
Can we use better function name?

Copy link
Contributor Author

@llama90 llama90 Dec 26, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. You are correct. In the current situation, as you mentioned, both Invalid and TypeError can occur. I think CheckListCastError or VerifyListCastFailure would be more appropriate. What do you think? (First, I chose CheckListCastError.)

Copy link
Contributor Author

@llama90 llama90 Dec 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kou Hello. When you have free time, could you please review it? Thank you :)

Copy link
Member

@kou kou Dec 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry! I reviewed this!

@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting review Awaiting review labels Dec 26, 2023
@github-actions github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Dec 26, 2023
@llama90 llama90 requested a review from kou December 26, 2023 03:15
kou
kou reviewed Dec 30, 2023
View reviewed changes
@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting change review Awaiting change review labels Dec 30, 2023
kou
kou reviewed Dec 31, 2023
View reviewed changes
@github-actions github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Dec 31, 2023
@llama90 llama90 requested a review from kou January 1, 2024 03:16
@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting change review Awaiting change review labels Jan 1, 2024
@github-actions github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Jan 1, 2024
kou
kou approved these changes Jan 1, 2024
View reviewed changes
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou kou merged commit 8a9f877 into apache:main Jan 1, 2024
@kou kou removed the awaiting change review Awaiting change review label Jan 1, 2024
@github-actions github-actions bot added the awaiting merge Awaiting merge label Jan 1, 2024
@conbench-apache-arrow
Copy link

conbench-apache-arrow bot commented Jan 1, 2024

After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 8a9f877.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them.

dgreiss pushed a commit to dgreiss/arrow that referenced this pull request Feb 19, 2024
@llama90 @dgreiss
apacheGH-39051: [C++] Use Cast() instead of CastTo() for List Scalar …
2cb414c 
…in test (apache#39353)

### Rationale for this change

Remove legacy code

### What changes are included in this PR?

Replace the legacy scalar CastTo implementation for List Scalar in test.

### Are these changes tested?

Yes. It is passed by existing test cases.

### Are there any user-facing changes?

No.

* Closes: apache#39051

Authored-by: Hyunseok Seo <hsseo0501@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kou kou kou approved these changes

Assignees

No one assigned

Labels

awaiting merge Awaiting merge Component: C++

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[C++] Add Compute Kernel for Casting from list_view to list

2 participants

@llama90 @kou