Skip to content

Conversation

@vibhatha
Copy link
Contributor

@vibhatha vibhatha commented Jan 4, 2024

Rationale for this change

This is a draft PR for fixing the dependabot PR #39409

What changes are included in this PR?

Upgrading com.google.errorprone to 2.24.0 for JDK11+ and restricting com.google.errorprone to 2.10 to JDK8.

Are these changes tested?

N/A. CIs are implicitly testing this including existing test cases.

Are there any user-facing changes?

No

dependabot bot and others added 2 commits January 4, 2024 15:26
Bumps [com.google.errorprone:error_prone_core](https://github.com/google/error-prone) from 2.4.0 to 2.24.0.
- [Release notes](https://github.com/google/error-prone/releases)
- [Commits](google/error-prone@v2.4.0...v2.24.0)

---
updated-dependencies:
- dependency-name: com.google.errorprone:error_prone_core
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@vibhatha
Copy link
Contributor Author

vibhatha commented Jan 4, 2024

@github-actions crossbow submit java

@github-actions
Copy link

github-actions bot commented Jan 4, 2024

Revision: d3d3308

Submitted crossbow builds: ursacomputing/crossbow @ actions-7ab1030fc9

Task Status
java-jars GitHub Actions
verify-rc-source-java-linux-almalinux-8-amd64 GitHub Actions
verify-rc-source-java-linux-conda-latest-amd64 GitHub Actions
verify-rc-source-java-linux-ubuntu-20.04-amd64 GitHub Actions
verify-rc-source-java-linux-ubuntu-22.04-amd64 GitHub Actions
verify-rc-source-java-macos-amd64 GitHub Actions

@vibhatha
Copy link
Contributor Author

vibhatha commented Jan 4, 2024

@lidavidm does this change make sense?

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting review Awaiting review labels Jan 4, 2024
@vibhatha vibhatha marked this pull request as ready for review January 5, 2024 00:11
@lidavidm lidavidm merged commit 42b995b into apache:main Jan 5, 2024
@lidavidm lidavidm removed the awaiting merge Awaiting merge label Jan 5, 2024
@github-actions github-actions bot added the awaiting merge Awaiting merge label Jan 5, 2024
@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 42b995b.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 6 possible false positives for unstable benchmarks that are known to sometimes produce them.

dgreiss pushed a commit to dgreiss/arrow that referenced this pull request Feb 19, 2024
…to 2.24.0 in /java (apache#39452)

### Rationale for this change

This is a draft PR for fixing the dependabot PR apache#39409

### What changes are included in this PR?

Upgrading `com.google.errorprone` to 2.24.0 for JDK11+ and restricting `com.google.errorprone` to 2.10 to JDK8. 

### Are these changes tested?

N/A. CIs are implicitly testing this including existing test cases. 

### Are there any user-facing changes?

No

Lead-authored-by: vibhatha <vibhatha@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
pribor pushed a commit to GlobalWebIndex/arrow that referenced this pull request Oct 24, 2025
…to 2.24.0 in /java (apache#39452)

### Rationale for this change

This is a draft PR for fixing the dependabot PR apache#39409

### What changes are included in this PR?

Upgrading `com.google.errorprone` to 2.24.0 for JDK11+ and restricting `com.google.errorprone` to 2.10 to JDK8. 

### Are these changes tested?

N/A. CIs are implicitly testing this including existing test cases. 

### Are there any user-facing changes?

No

Lead-authored-by: vibhatha <vibhatha@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants