GH-39482: [JS] Refactor imports #39483
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component: JavaScript
awaiting committer review
domoritz
changed the title
trxcllnt
reviewed
Jan 5, 2024
Co-authored-by: Paul Taylor <178183+trxcllnt@users.noreply.github.com>
domoritz
changed the title
domoritz
changed the title
trxcllnt
approved these changes
Apr 16, 2024
|
After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit 5abd933. There were 12 benchmark results indicating a performance regression:
The full Conbench report has more details. It also includes information about 9 possible false positives for unstable benchmarks that are known to sometimes produce them. |
domoritz
added a commit
to domoritz/arrow
that referenced
this pull request
Apr 17, 2024
* use `node:` prefix for node imports * remove `import` for types where it makes sense * Closes: apache#39482 * GitHub Issue: apache#39482 --------- Co-authored-by: Paul Taylor <178183+trxcllnt@users.noreply.github.com>
raulcd
pushed a commit
that referenced
this pull request
Apr 29, 2024
vibhatha
pushed a commit
to vibhatha/arrow
that referenced
this pull request
May 25, 2024
* use `node:` prefix for node imports * remove `import` for types where it makes sense * Closes: apache#39482 * GitHub Issue: apache#39482 --------- Co-authored-by: Paul Taylor <178183+trxcllnt@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use
node:prefix for node importsremove
importfor types where it makes senseCloses: [JS] Use node: prefix and import types instead of using import #39482
GitHub Issue: [JS] Use node: prefix and import types instead of using import #39482