GH-39946: [Java] Bump com.puppycrawl.tools:checkstyle from 8.19 to 8.29

java/adapter/jdbc/src/main/java/org/apache/arrow/adapter/jdbc/Constants.java

@@ -21,7 +21,8 @@
  * String constants used for metadata returned on Vectors.
  */
 public class Constants {
-  private Constants() {}
+  private Constants() {
+  }
 
   public static final String SQL_CATALOG_NAME_KEY = "SQL_CATALOG_NAME";
   public static final String SQL_SCHEMA_NAME_KEY = "SQL_SCHEMA_NAME";

java/adapter/jdbc/src/test/java/org/apache/arrow/adapter/jdbc/MockPreparedStatement.java

@@ -231,7 +231,8 @@ public void setDate(int parameterIndex, Date x, Calendar cal) throws SQLExceptio
   }
 
   @Override
-  public void setTime(int parameterIndex, Time x, Calendar cal) throws SQLException {}
+  public void setTime(int parameterIndex, Time x, Calendar cal) throws SQLException {
+  }
 
   @Override
   public void setTimestamp(int parameterIndex, Timestamp x, Calendar cal) throws SQLException {
@@ -241,7 +242,8 @@ public void setTimestamp(int parameterIndex, Timestamp x, Calendar cal) throws S
   }
 
   @Override
-  public void setNull(int parameterIndex, int sqlType, String typeName) throws SQLException {}
+  public void setNull(int parameterIndex, int sqlType, String typeName) throws SQLException {
+  }
 
   @Override
   public void setURL(int parameterIndex, URL x) throws SQLException {
@@ -259,62 +261,80 @@ public void setRowId(int parameterIndex, RowId x) throws SQLException {
   }
 
   @Override
-  public void setNString(int parameterIndex, String value) throws SQLException {}
+  public void setNString(int parameterIndex, String value) throws SQLException {
+  }
 
   @Override
   public void setNCharacterStream(int parameterIndex, Reader value, long length)
-      throws SQLException {}
+      throws SQLException {
+  }
 
   @Override
-  public void setNClob(int parameterIndex, NClob value) throws SQLException {}
+  public void setNClob(int parameterIndex, NClob value) throws SQLException {
+  }
 
   @Override
-  public void setClob(int parameterIndex, Reader reader, long length) throws SQLException {}
+  public void setClob(int parameterIndex, Reader reader, long length) throws SQLException {
+  }
 
   @Override
   public void setBlob(int parameterIndex, InputStream inputStream, long length)
-      throws SQLException {}
+      throws SQLException {
+  }
 
   @Override
-  public void setNClob(int parameterIndex, Reader reader, long length) throws SQLException {}
+  public void setNClob(int parameterIndex, Reader reader, long length) throws SQLException {
+  }
 
   @Override
-  public void setSQLXML(int parameterIndex, SQLXML xmlObject) throws SQLException {}
+  public void setSQLXML(int parameterIndex, SQLXML xmlObject) throws SQLException {
+  }
 
   @Override
   public void setObject(int parameterIndex, Object x, int targetSqlType, int scaleOrLength)
-      throws SQLException {}
+      throws SQLException {
+  }
 
   @Override
-  public void setAsciiStream(int parameterIndex, InputStream x, long length) throws SQLException {}
+  public void setAsciiStream(int parameterIndex, InputStream x, long length) throws SQLException {
+  }
 
   @Override
-  public void setBinaryStream(int parameterIndex, InputStream x, long length) throws SQLException {}
+  public void setBinaryStream(int parameterIndex, InputStream x, long length) throws SQLException {
+  }
 
   @Override
   public void setCharacterStream(int parameterIndex, Reader reader, long length)
-      throws SQLException {}
+      throws SQLException {
+  }
 
   @Override
-  public void setAsciiStream(int parameterIndex, InputStream x) throws SQLException {}
+  public void setAsciiStream(int parameterIndex, InputStream x) throws SQLException {
+  }
 
   @Override
-  public void setBinaryStream(int parameterIndex, InputStream x) throws SQLException {}
+  public void setBinaryStream(int parameterIndex, InputStream x) throws SQLException {
+  }
 
   @Override
-  public void setCharacterStream(int parameterIndex, Reader reader) throws SQLException {}
+  public void setCharacterStream(int parameterIndex, Reader reader) throws SQLException {
+  }
 
   @Override
-  public void setNCharacterStream(int parameterIndex, Reader value) throws SQLException {}
+  public void setNCharacterStream(int parameterIndex, Reader value) throws SQLException {
+  }
 
   @Override
-  public void setClob(int parameterIndex, Reader reader) throws SQLException {}
+  public void setClob(int parameterIndex, Reader reader) throws SQLException {
+  }
 
   @Override
-  public void setBlob(int parameterIndex, InputStream inputStream) throws SQLException {}
+  public void setBlob(int parameterIndex, InputStream inputStream) throws SQLException {
+  }
 
   @Override
-  public void setNClob(int parameterIndex, Reader reader) throws SQLException {}
+  public void setNClob(int parameterIndex, Reader reader) throws SQLException {
+  }
 
   @Override
   public ResultSet executeQuery(String sql) throws SQLException {
@@ -327,7 +347,8 @@ public int executeUpdate(String sql) throws SQLException {
   }
 
   @Override
-  public void close() throws SQLException {}
+  public void close() throws SQLException {
+  }
 
   @Override
   public int getMaxFieldSize() throws SQLException {

java/adapter/jdbc/src/test/java/org/apache/arrow/adapter/jdbc/ResultSetUtility.java

@@ -348,7 +348,8 @@ public static class MockColumnMetaData {
       private int displaySize;
 
 
-      private MockColumnMetaData() {}
+      private MockColumnMetaData() {
+      }
 
       private String getLabel() {
         return label;

java/adapter/orc/src/main/java/org/apache/arrow/adapter/orc/OrcJniUtils.java

@@ -32,7 +32,8 @@ class OrcJniUtils {
   private static final String LIBRARY_NAME = "arrow_orc_jni";
   private static boolean isLoaded = false;
 
-  private OrcJniUtils() {}
+  private OrcJniUtils() {
+  }
 
   static void loadOrcAdapterLibraryFromJar()
           throws IOException, IllegalAccessException {

java/dev/checkstyle/checkstyle.xml

@@ -60,6 +60,11 @@
       <property name="eachLine" value="true"/>
     </module>
 
+    <module name="LineLength">
+        <property name="max" value="120"/>
+        <property name="ignorePattern" value="^package.*|^import.*|a href|href|http://|https://|ftp://"/>
+    </module>
+
     <module name="TreeWalker">
         <module name="OuterTypeFilename"/>
         <module name="IllegalTokenText">
@@ -72,10 +77,6 @@
             <property name="allowByTailComment" value="true"/>
             <property name="allowNonPrintableEscapes" value="true"/>
         </module>
-        <module name="LineLength">
-            <property name="max" value="120"/>
-            <property name="ignorePattern" value="^package.*|^import.*|a href|href|http://|https://|ftp://"/>
-        </module>
         <module name="OneTopLevelClass"/>
         <module name="NoLineWrap"/>
         <module name="EmptyBlock">
@@ -223,13 +224,12 @@
         <module name="JavadocMethod">
             <property name="scope" value="public"/>
             <property name="allowMissingParamTags" value="true"/>
-            <property name="allowMissingThrowsTags" value="true"/>
             <property name="allowMissingReturnTag" value="true"/>
-            <property name="minLineCount" value="2"/>
             <property name="allowedAnnotations" value="Override, Test"/>
-            <property name="allowThrowsTagsForSubclasses" value="true"/>
-            <!-- This seems partially broken under JDK >= 9. -->
-            <property name="suppressLoadErrors" value="true"/>
+        </module>
+        <module name="MissingJavadocMethod">
+            <property name="scope" value="public"/>
+            <property name="minLineCount" value="2"/>
             <property name="ignoreMethodNamesRegex" value="main"/>
         </module>
         <module name="JavadocType">

java/dev/checkstyle/suppressions.xml

@@ -40,5 +40,5 @@
   <suppress checks="NoFinalizer|OverloadMethodsDeclarationOrder|VariableDeclarationUsageDistance" files=".*" />
 
   <!-- No license header in generated file -->
-  <suppress checks="header" files="flight.properties"/>
+  <suppress checks="header|LineLength" files="flight.properties"/>
 </suppressions>

java/flight/flight-core/src/main/java/org/apache/arrow/flight/FlightClient.java

@@ -437,7 +437,8 @@ public ClientStreamListener getWriter() {
      */
     public void getResult() {
       // After exchange is complete, make sure stream is drained to propagate errors through reader
-      while (reader.next()) { };
+      while (reader.next()) {
+      }
     }
 
     /** Shut down the streams in this call. */

java/flight/flight-core/src/main/java/org/apache/arrow/flight/FlightGrpcUtils.java

@@ -125,7 +125,8 @@ public void enterIdle() {
     }
   }
 
-  private FlightGrpcUtils() {}
+  private FlightGrpcUtils() {
+  }
 
   /**
    * Creates a Flight service.

java/flight/flight-core/src/main/java/org/apache/arrow/flight/FlightStream.java

@@ -194,7 +194,8 @@ public void close() throws Exception {
           }
         }
         // Drain the stream without the lock (as next() implicitly needs the lock)
-        while (next()) { }
+        while (next()) {
+        }
       } catch (FlightRuntimeException e) {
         suppressor = e;
       }

java/flight/flight-core/src/main/java/org/apache/arrow/flight/OutboundStreamListener.java

@@ -119,5 +119,6 @@ default void start(VectorSchemaRoot root, DictionaryProvider dictionaries) {
    * <p>The default value can be toggled globally by setting the JVM property arrow.flight.enable_zero_copy_write
    * or the environment variable ARROW_FLIGHT_ENABLE_ZERO_COPY_WRITE.
    */
-  default void setUseZeroCopy(boolean enabled) {}
+  default void setUseZeroCopy(boolean enabled) {
+  }
 }

java/flight/flight-core/src/main/java/org/apache/arrow/flight/auth/AuthConstants.java

@@ -47,5 +47,6 @@ public byte[] parseBytes(byte[] serialized) {
 
   public static final Context.Key<String> PEER_IDENTITY_KEY = Context.keyWithDefault("arrow-flight-peer-identity", "");
 
-  private AuthConstants() {}
+  private AuthConstants() {
+  }
 }

java/flight/flight-core/src/main/java/org/apache/arrow/flight/auth/ServerAuthWrapper.java

@@ -115,7 +115,9 @@ public boolean hasNext() {
     @Override
     public void onError(Throwable t) {
       completed = true;
-      while (future == null) {/* busy wait */}
+      while (future == null) {
+        /* busy wait */
+      }
       future.cancel(true);
     }
 

java/flight/flight-core/src/test/java/org/apache/arrow/flight/TestClientMiddleware.java

@@ -303,10 +303,12 @@ public void onBeforeSendingHeaders(CallHeaders outgoingHeaders) {
     }
 
     @Override
-    public void onCallCompleted(CallStatus status) {}
+    public void onCallCompleted(CallStatus status) {
+    }
 
     @Override
-    public void onCallErrored(Throwable err) {}
+    public void onCallErrored(Throwable err) {
+    }
   }
 
   static class MultiHeaderClientMiddlewareFactory implements FlightClientMiddleware.Factory {
@@ -356,6 +358,7 @@ public void onHeadersReceived(CallHeaders incomingHeaders) {
     }
 
     @Override
-    public void onCallCompleted(CallStatus status) {}
+    public void onCallCompleted(CallStatus status) {
+    }
   }
 }

java/flight/flight-integration-tests/src/main/java/org/apache/arrow/flight/integration/tests/OrderedScenario.java

@@ -55,7 +55,8 @@ public FlightProducer producer(BufferAllocator allocator, Location location) thr
   }
 
   @Override
-  public void buildServer(FlightServer.Builder builder) throws Exception {}
+  public void buildServer(FlightServer.Builder builder) throws Exception {
+  }
 
   @Override
   public void client(BufferAllocator allocator, Location location, FlightClient client)

java/flight/flight-sql-jdbc-core/src/main/java/org/apache/arrow/driver/jdbc/utils/IntervalStringUtils.java

@@ -31,7 +31,8 @@ public final class IntervalStringUtils {
   /**
    * Constructor Method of class.
    */
-  private IntervalStringUtils( ) {}
+  private IntervalStringUtils( ) {
+  }
 
   /**
    * Formats a period similar to Oracle INTERVAL YEAR TO MONTH data type<br>.

java/flight/flight-sql-jdbc-core/src/test/java/org/apache/arrow/driver/jdbc/client/utils/ClientAuthenticationUtilsTest.java

@@ -84,7 +84,7 @@ public void testGetDefaultKeyStoreInstancePassword() throws IOException,
 
       keyStoreMockedStatic
          .when(() -> ClientAuthenticationUtils.getDefaultKeyStoreInstance("changeit"))
-         .thenReturn(keyStoreMock);
+          .thenReturn(keyStoreMock);
       KeyStore receiveKeyStore = ClientAuthenticationUtils.getDefaultKeyStoreInstance("changeit");
       Assert.assertEquals(receiveKeyStore, keyStoreMock);
     }

java/gandiva/src/main/java/org/apache/arrow/gandiva/evaluator/ConfigurationBuilder.java

@@ -43,7 +43,8 @@ public static ConfigOptions getDefault() {
       return new ConfigOptions();
     }
 
-    public ConfigOptions() {}
+    public ConfigOptions() {
+    }
 
     public ConfigOptions withOptimize(boolean optimize) {
       this.optimize = optimize;

java/gandiva/src/main/java/org/apache/arrow/gandiva/evaluator/DecimalTypeUtil.java

@@ -23,7 +23,8 @@
  * Utility methods for working with {@link Decimal} values.
  */
 public class DecimalTypeUtil {
-  private DecimalTypeUtil() {}
+  private DecimalTypeUtil() {
+  }
 
   /**
    * Enum for supported mathematical operations.

java/gandiva/src/main/java/org/apache/arrow/gandiva/expression/ArrowTypeHelper.java

@@ -33,7 +33,8 @@
  * Utility methods to convert between Arrow and Gandiva types.
  */
 public class ArrowTypeHelper {
-  private ArrowTypeHelper() {}
+  private ArrowTypeHelper() {
+  }
 
   static final int WIDTH_8 = 8;
   static final int WIDTH_16 = 16;

java/gandiva/src/main/java/org/apache/arrow/gandiva/expression/TreeBuilder.java

@@ -29,7 +29,8 @@
  * Contains helper functions for constructing expression trees.
  */
 public class TreeBuilder {
-  private TreeBuilder() {}
+  private TreeBuilder() {
+  }
 
   /**
    * Helper functions to create literal constants.

java/maven/pom.xml

@@ -235,7 +235,7 @@
           <dependency>
             <groupId>com.puppycrawl.tools</groupId>
             <artifactId>checkstyle</artifactId>
-            <version>8.19</version>
+            <version>8.29</version>
           </dependency>
           <dependency>
             <groupId>org.slf4j</groupId>