GH-39712: [Java] Enable code review and formatting code through Spotless Maven plugin #39713
Conversation
|
|
github-actions
bot
added
awaiting review
|
Please consider: Initial formatting implementations will require a large number of file changes. Among the main changes that need to be reviewed are:
|
|
@davisusanibar shall we hold this merge until we merge the errorprone fixes? |
Hi @vibhatha, this sounds like a good idea to me. |
|
The documentation has been added, please review if more details need to be added. |
|
|
(1) did you mean to leave this in draft |
Our plan was to merge first #39777 #39713 (comment)
Let me break this down into modules. |
| * <p>CHAR --> ArrowType.Utf8 NCHAR --> ArrowType.Utf8 VARCHAR --> ArrowType.Utf8 NVARCHAR --> | ||
| * ArrowType.Utf8 LONGVARCHAR --> ArrowType.Utf8 LONGNVARCHAR --> ArrowType.Utf8 NUMERIC --> | ||
| * ArrowType.Decimal(precision, scale) DECIMAL --> ArrowType.Decimal(precision, scale) BIT --> | ||
| * ArrowType.Bool TINYINT --> ArrowType.Int(8, signed) SMALLINT --> ArrowType.Int(16, signed) | ||
| * INTEGER --> ArrowType.Int(32, signed) BIGINT --> ArrowType.Int(64, signed) REAL --> | ||
| * ArrowType.FloatingPoint(FloatingPointPrecision.SINGLE) FLOAT --> | ||
| * ArrowType.FloatingPoint(FloatingPointPrecision.SINGLE) DOUBLE --> | ||
| * ArrowType.FloatingPoint(FloatingPointPrecision.DOUBLE) BINARY --> ArrowType.Binary VARBINARY --> | ||
| * ArrowType.Binary LONGVARBINARY --> ArrowType.Binary DATE --> ArrowType.Date(DateUnit.MILLISECOND) | ||
| * TIME --> ArrowType.Time(TimeUnit.MILLISECOND, 32) TIMESTAMP --> | ||
| * ArrowType.Timestamp(TimeUnit.MILLISECOND, timezone=null) CLOB --> ArrowType.Utf8 BLOB --> | ||
| * ArrowType.Binary |
There was a problem hiding this comment.
Here's an example of a change we wouldn't want. There might be a few of these types of issues around.
There was a problem hiding this comment.
Arguably, the original formatting is wrong (javadoc would have rendered it wrong too) and this should've been an HTML definition list
There was a problem hiding this comment.
But yes, it'll be easier to review if this is broken down
github-actions
bot
added
awaiting committer review
|
In order to define a better alternative solution, the current pull request has been closed |
Created an issue: #40757 |
4 participants
Rationale for this change
To enable code review and formatting code by using Spotless Maven plugin.
What changes are included in this PR?
Are these changes tested?
By ´mvn spotless:apply´
Are there any user-facing changes?
No