GH-40142: [Python] Allow FileInfo instances to be passed to dataset init #40143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
fjetter
changed the title
|
|
fjetter
force-pushed
the
fileinfo_pyarrow_dataset
branch
from
cb03e28 to
dbdc9e2
Compare
Contributor
Author
|
the appveyor build seems to have timed out while compiling |
Contributor
Author
|
@jorisvandenbossche can I ask you to take a look at this? |
jorisvandenbossche
approved these changes
Feb 27, 2024
Member
jorisvandenbossche
left a comment
jorisvandenbossche
left a comment
There was a problem hiding this comment.
Thanks for the PR, sounds as a useful addition, and looks good!
github-actions
bot
added
awaiting merge
Contributor
Author
|
Thank you! |
|
After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit c57115d. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Closes #40142
I'm developing a new dask integration with pyarrow parquet reader (see dask/dask-expr#882) and want to rely on the pyarrow Filesystem more.
Right now, we are performing a list operation ourselves to get all touched files and I would like to pass the retrieved
FileInfoobjects directly to the dataset constructor. This API is already exposed in C++ and this PR is adding the necessary python bindings.The benefit of this is that there is API is that it cuts the need to perform additional HEAD requests to a remote storage.
This came up in #38389 (comment) and there's been related work already with #37857
What changes are included in this PR?
Python bindings for the
DatasetFactoryconstructor that accepts a list/vector ofFileInfoobjects.Are these changes tested?
I slightly modified the minio test setup such that the prometheus endpoint is exposed. This can be used to assert that there hasn't been any HEAD requests.I ended up removing this again since parsing the response is a bit brittle.Are there any user-facing changes?
FileInfoobjects #40142