Skip to content

Conversation

@vibhatha
Copy link
Contributor

Rationale for this change

The dependabot PR includes a modification to upgrade the maven dependency plugin usage from 3.1.2 to 3.6.1. But just updating the versions doesn't do the expected. This is a replacement PR which completes the required upgrade.

What changes are included in this PR?

Bump org.apache.maven.plugins:maven-dependency-plugin from 3.1.2 to 3.6.1.
Required minor refactor of Integration util to be moved to tests from source.

Are these changes tested?

Tested by existing test cases.

Are there any user-facing changes?

No

@vibhatha
Copy link
Contributor Author

@github-actions crossbow submit java

@github-actions github-actions bot added the awaiting review Awaiting review label Feb 20, 2024
@github-actions
Copy link

Revision: f62b7746d31ec3308eb7a6c486db1dd791ccd453

Submitted crossbow builds: ursacomputing/crossbow @ actions-25ce96495f

Task Status
java-jars GitHub Actions
verify-rc-source-java-linux-almalinux-8-amd64 GitHub Actions
verify-rc-source-java-linux-conda-latest-amd64 GitHub Actions
verify-rc-source-java-linux-ubuntu-20.04-amd64 GitHub Actions
verify-rc-source-java-linux-ubuntu-22.04-amd64 GitHub Actions
verify-rc-source-java-macos-amd64 GitHub Actions

@vibhatha
Copy link
Contributor Author

@github-actions crossbow submit java

@github-actions
Copy link

Revision: 94a94b343c05de7cee39e11d945e7d5505b39786

Submitted crossbow builds: ursacomputing/crossbow @ actions-d328cd87db

Task Status
java-jars GitHub Actions
verify-rc-source-java-linux-almalinux-8-amd64 GitHub Actions
verify-rc-source-java-linux-conda-latest-amd64 GitHub Actions
verify-rc-source-java-linux-ubuntu-20.04-amd64 GitHub Actions
verify-rc-source-java-linux-ubuntu-22.04-amd64 GitHub Actions
verify-rc-source-java-macos-amd64 GitHub Actions

@vibhatha
Copy link
Contributor Author

@davisusanibar @danepitkin could you please take look?
There are 3 CIs failing but the crossbows for Java are passing. I am wondering do we need to include jackson dependencies both test and compile since Python is using the jar?

@vibhatha vibhatha marked this pull request as ready for review February 21, 2024 23:13
@vibhatha vibhatha requested a review from lidavidm as a code owner February 21, 2024 23:13
@lidavidm
Copy link
Member

We could also stop using ByteBufferBackedInputStream

java/pom.xml Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the comment above this line still applicable?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to make a choice regarding the option we should take.

@vibhatha vibhatha force-pushed the feat-maven-plugin-bump branch from 94a94b3 to 1ad01b5 Compare May 29, 2024 08:15
@github-actions github-actions bot added awaiting committer review Awaiting committer review and removed awaiting review Awaiting review labels May 29, 2024
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, will this work? We need this to be in the JAR so we can run this for integration tests.

@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting committer review Awaiting committer review labels May 29, 2024
@vibhatha vibhatha closed this Jun 4, 2024
@vibhatha
Copy link
Contributor Author

vibhatha commented Jun 4, 2024

Closing this PR in favor of a waiting for a suitable plugin version update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants