-
Notifications
You must be signed in to change notification settings - Fork 4k
GH-40384: [Python] Expand the C Device Interface bindings to support import on CUDA device #40385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jorisvandenbossche
merged 17 commits into
apache:main
from
jorisvandenbossche:device-interface-cuda
Jun 19, 2024
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
ef8be15
support + test cuda device interface (with hardcoded dependency on li…
jorisvandenbossche 143f511
test on cpu
jorisvandenbossche 42e883c
try with #define
jorisvandenbossche 05dd7a5
try with helper function duplicated in _cuda.pyx
jorisvandenbossche 83b0d58
fixup import from pyarrow._cuda
jorisvandenbossche fd08ac1
fix linting issues in test_cuda.py
jorisvandenbossche 3667071
Merge remote-tracking branch 'upstream/main' into device-interface-cuda
jorisvandenbossche 1bfc05c
undo non-test changes + try import pyarrow.cuda instead to register
jorisvandenbossche 65847db
Merge remote-tracking branch 'upstream/main' into device-interface-cuda
jorisvandenbossche c35df80
import on demand
jorisvandenbossche 76a3a5e
linting: suppress unused import error
jorisvandenbossche 326b730
linter second try
jorisvandenbossche 73bfca1
only load on demand if we actually receive a CUDA device array
jorisvandenbossche 78a7fb5
Merge remote-tracking branch 'upstream/main' into device-interface-cuda
jorisvandenbossche 820bb47
Merge remote-tracking branch 'upstream/main' into device-interface-cuda
jorisvandenbossche 3e9f913
address feedback: raise informative error message
jorisvandenbossche eca6869
Merge remote-tracking branch 'upstream/main' into device-interface-cuda
jorisvandenbossche File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a GH issue for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not yet (I still need to create a whole set of issues to track the work I am planning the next months to improve the Device / MemoryManager bindings in Python)