-
Notifications
You must be signed in to change notification settings - Fork 4k
GH-40077: [CI] Use GitHub hosted M1 macOS runner #40437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
|
@github-actions crossbow submit java-jars wheel-macos-*-arm64 r-binary-packages |
|
@github-actions crossbow submit verify-rc-source-*-macos-arm64 |
This comment was marked as outdated.
This comment was marked as outdated.
|
Can we use Lines 1007 to 1014 in 6a7a6ee
Is |
This comment was marked as outdated.
This comment was marked as outdated.
|
@github-actions crossbow submit java-jars wheel-macos--arm64 r-binary-packages verify-rc-source--macos-arm64 |
This comment was marked as outdated.
This comment was marked as outdated.
|
Imo I think we can drop the self hosted M1 for r-binary-packages as well, then we can retire the runner completely. It don't recall ever having an issue with the package related to the macos version (and x86 is even run on macos 13). The issues are usually with the environment setup (e.g. gnu libtool being on the path etc.) |
|
OK. Let's try with GitHub hosted runner. |
|
@github-actions crossbow submit java-jars wheel-macos-big-sur-cp310-arm64 r-binary-packages verify-rc-source-cpp-macos-arm64 |
This comment was marked as outdated.
This comment was marked as outdated.
|
@github-actions crossbow submit wheel-macos-big-sur-cp310-* r-binary-packages |
This comment was marked as outdated.
This comment was marked as outdated.
|
@github-actions crossbow submit wheel-macos-big-sur-cp310-* r-binary-packages |
This comment was marked as outdated.
This comment was marked as outdated.
|
@github-actions crossbow submit wheel-macos--cp310- |
This comment was marked as outdated.
This comment was marked as outdated.
|
@github-actions crossbow submit wheel-macos--cp310- |
This comment was marked as outdated.
This comment was marked as outdated.
|
@github-actions crossbow submit wheel-macos--cp310- |
|
@assignUser Could you check the artifacts of https://github.com/ursacomputing/crossbow/actions/runs/8220036683 ? It uses GitHub hosted runners. |
This comment was marked as outdated.
This comment was marked as outdated.
|
@github-actions crossbow submit wheel-macos--cp310- |
This comment was marked as outdated.
This comment was marked as outdated.
|
Could we also add a PR C++ job on macOS ARM64? (or perhaps as a separate PR) |
|
Hmm. It seems that we need #40418 for the wheel failures. |
|
@github-actions crossbow submit wheel-macos--cp38- |
|
Revision: a9db9da71dd94785eaa01fffbe7a0c2ec045f996 Submitted crossbow builds: ursacomputing/crossbow @ actions-d07c449d1f
|
|
I suppose the "install packages" step in the arm64 wheel builds will get faster once vcpkg results are cached? |
Yes. The previous arm64 template doesn't use NuGet based cache but I unified amd64/arm64 templates in this PR. So the arm64 template can also use NuGet based cache. It'll reduce build time. |
|
Should we wait for #40418 before we merge this? |
|
I think it would be better to wait for #40418. |
a9db9da to
de8ae54
Compare
|
@github-actions crossbow submit wheel-macos-*-arm64 |
|
Revision: de8ae54 Submitted crossbow builds: ursacomputing/crossbow @ actions-7a78f0a41d
|
|
Green. I'll merge this. |
|
After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 7d290bd. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Rationale for this change
If we use GitHub hosted M1 macOS runner instead of self-hosted M1 macOS runner, we don't need to maintain self-hosted M1 macOS runner.
What changes are included in this PR?
Use GitHub hosted M1 macOS runner except
r-binary-packages'sr-packagesjob. It uses macOS 11 but GitHub hosted M1 macOS runner is 13 or 14.Are these changes tested?
Yes.
Are there any user-facing changes?
No.