Skip to content

Conversation

@vibhatha
Copy link
Contributor

@vibhatha vibhatha commented Mar 20, 2024

What changes are included in this PR?

Removing static imports of UTF_8. This has been identified as a minor enhancement as documented here: #39752 and discussed in a review here.

Are these changes tested?

Tested by existing test cases.

Are there any user-facing changes?

No

@vibhatha
Copy link
Contributor Author

@github-actions crossbow submit -g java

@github-actions
Copy link

Revision: 129c7ea

Submitted crossbow builds: ursacomputing/crossbow @ actions-e920eb11b8

Task Status
java-jars GitHub Actions
verify-rc-source-java-linux-almalinux-8-amd64 GitHub Actions
verify-rc-source-java-linux-conda-latest-amd64 GitHub Actions
verify-rc-source-java-linux-ubuntu-20.04-amd64 GitHub Actions
verify-rc-source-java-linux-ubuntu-22.04-amd64 GitHub Actions
verify-rc-source-java-macos-amd64 GitHub Actions

@vibhatha vibhatha marked this pull request as ready for review March 20, 2024 03:30
@vibhatha vibhatha requested a review from lidavidm as a code owner March 20, 2024 03:30
@lidavidm lidavidm merged commit 3e9b94f into apache:main Mar 20, 2024
@lidavidm lidavidm removed the awaiting review Awaiting review label Mar 20, 2024
@github-actions github-actions bot added the awaiting merge Awaiting merge label Mar 20, 2024
@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 3e9b94f.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them.

pribor pushed a commit to GlobalWebIndex/arrow that referenced this pull request Oct 24, 2025
…0683)

### What changes are included in this PR?

Removing static imports of UTF_8. This has been identified as a minor enhancement as documented here: apache#39752 and discussed in a review [here](apache#39529 (comment)). 

### Are these changes tested?

Tested by existing test cases. 

### Are there any user-facing changes?

No
* GitHub Issue: apache#39752

Authored-by: Vibhatha Abeykoon <vibhatha@gmail.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants