Skip to content

GH-40863: [C++] Fix TSAN link error for module library #40864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pitrou merged 2 commits into from
Mar 28, 2024
Merged

GH-40863: [C++] Fix TSAN link error for module library #40864

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d9fb159
Fix TSAN link error for module library
zanmato1984 Mar 28, 2024
a8c7efa
Fix
zanmato1984 Mar 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions cpp/cmake_modules/san-config.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@ if(${ARROW_USE_TSAN})

# Some of the above also need to be passed to the linker.
set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} -pie -fsanitize=thread")
set(CMAKE_MODULE_LINKER_FLAGS "${CMAKE_MODULE_LINKER_FLAGS} -pie -fsanitize=thread")

# Strictly speaking, TSAN doesn't require dynamic linking. But it does
# require all code to be position independent, and the easiest way to
Expand Down