ARROW-676: move from MinorType to FieldType in ValueVectors to carry all the relevant type bits #409
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienledem
force-pushed
the
minor_field
branch
4 times, most recently
from
33a5226 to
89b690a
Compare
julienledem
changed the title
wesm
approved these changes
Mar 29, 2017
Member
wesm
left a comment
wesm
left a comment
There was a problem hiding this comment.
This seems reasonable to me, better encapsulating the type metadata. Needs to be rebased
Member
|
@julienledem per discussion in #452 I think if we rebase and merge this, it will help with adding new data types. @elahrvivaz do you have any comments on the implementation? |
Contributor
|
nope, looks good to me |
…all the relevant type bits
Member
Author
|
rebased |
Member
|
OK, let's merge this after the build runs, in case it causes any conflict with #475? |
Member
|
+1 |
pribor
pushed a commit
to GlobalWebIndex/arrow
that referenced
this pull request
Oct 24, 2025
…all the relevant type bits I'm adding all the Type information to the vector with FieldType. This avoids losing information and carrying around extra type metadata that can not go in the MinorType enum (for example: decimals' precision and dictionary encoding) Author: Julien Le Dem <julien@dremio.com> Closes apache#409 from julienledem/minor_field and squashes the following commits: 0407e63 [Julien Le Dem] ARROW-676: move from MinorType to FieldType in ValueVectors to carry all the relevant type bits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm adding all the Type information to the vector with FieldType.
This avoids losing information and carrying around extra type metadata that can not go in the MinorType enum (for example: decimals' precision and dictionary encoding)