Skip to content

GH-38889: [C++] Fix redundant move warnings #41107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pitrou merged 1 commit into from
Apr 16, 2024
Merged

GH-38889: [C++] Fix redundant move warnings #41107

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions cpp/src/arrow/util/decimal.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ class ARROW_EXPORT Decimal128 : public BasicDecimal128 {
std::pair<Decimal128, Decimal128> result;
auto dstatus = BasicDecimal128::Divide(divisor, &result.first, &result.second);
ARROW_RETURN_NOT_OK(ToArrowStatus(dstatus));
return std::move(result);
return result;
}

/// \brief Convert the Decimal128 value to a base 10 decimal string with the given
Expand Down Expand Up @@ -118,7 +118,7 @@ class ARROW_EXPORT Decimal128 : public BasicDecimal128 {
Decimal128 out;
auto dstatus = BasicDecimal128::Rescale(original_scale, new_scale, &out);
ARROW_RETURN_NOT_OK(ToArrowStatus(dstatus));
return std::move(out);
return out;
}

/// \brief Convert to a signed integer
Expand Down Expand Up @@ -218,7 +218,7 @@ class ARROW_EXPORT Decimal256 : public BasicDecimal256 {
Decimal256 out;
auto dstatus = BasicDecimal256::Rescale(original_scale, new_scale, &out);
ARROW_RETURN_NOT_OK(ToArrowStatus(dstatus));
return std::move(out);
return out;
}

/// Divide this number by right and return the result.
Expand All @@ -235,7 +235,7 @@ class ARROW_EXPORT Decimal256 : public BasicDecimal256 {
std::pair<Decimal256, Decimal256> result;
auto dstatus = BasicDecimal256::Divide(divisor, &result.first, &result.second);
ARROW_RETURN_NOT_OK(ToArrowStatus(dstatus));
return std::move(result);
return result;
}

/// \brief Convert from a big-endian byte representation. The length must be
Expand Down