Skip to content

Conversation

@kevingurney
Copy link
Member

@kevingurney kevingurney commented Apr 25, 2024

Rationale for this change

What changes are included in this PR?

  1. Pin back MATLAB CI workflow to use macos-12.
  2. Pin back MATLAB crossbow packaging workflow to use macos-12.

Are these changes tested?

I will run a crossbow job and ensure that the MATLAB CI workflow passes successfully before merging this PR.

Are there any user-facing changes?

No.

Future Directions

  1. [CI][MATLAB][Packaging] Add support for MATLAB R2024a in CI and crossbow packaging workflows #41385

Notes

  1. Thanks @sgilmore10 for your help with this pull request!

…not officially supported on `macos-14` (i.e. `macos-latest`).
…ATLAB R2023a is not officially supported on `macos-14` (i.e. `macos-latest`).
@github-actions github-actions bot added the awaiting committer review Awaiting committer review label Apr 25, 2024
@kevingurney
Copy link
Member Author

All CI workflow checks as passing now that the macOS version is pinned back to macos-12.

I will now submit a crossbow job to verify that the crossbow packaging workflow also works as expected when pinned back to macos-12.

@kevingurney
Copy link
Member Author

@github-actions crossbow submit matlab

@github-actions
Copy link

Revision: cf47c75

Submitted crossbow builds: ursacomputing/crossbow @ actions-019657fd7f

Task Status
matlab GitHub Actions

@sgilmore10
Copy link
Member

+1

Looks good! Let's verify the MLTBX file created by the crossbow job works as expected before merging. Thanks!

@kevingurney
Copy link
Member Author

Crossbow job passed successfully.

@kevingurney
Copy link
Member Author

+1

@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 6578c3b.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them.

raulcd pushed a commit that referenced this pull request Apr 29, 2024
…os-latest` change to `macos-14` (#41384)

### Rationale for this change

* The MATLAB macOS CI workflow is failing because of the recent change to `macos-latest` from `macos-12` to `macos-14`.
* In https://github.blog/changelog/2024-01-30-github-actions-macos-14-sonoma-is-now-available/ it is mentioned that the transition to `macos-14` was planned for April-June 2024.
* As noted in the [Platform Road Map](https://www.mathworks.com/support/requirements/platform-road-map.html), MATLAB R2023a is not officially supported with `macos-14`.
* Until we can move to building against MATLAB R2024a (latest available version of MATLAB), it makes sense to pin back the macOS version to version 14.

### What changes are included in this PR?

1. Pin back MATLAB CI workflow to use `macos-12`.
2. Pin back MATLAB crossbow packaging workflow to use `macos-12`.

### Are these changes tested?

I will run a crossbow job and ensure that the MATLAB CI workflow passes successfully before merging this PR.

### Are there any user-facing changes?

No.

### Future Directions

1.  #41385

### Notes

1. Thanks @ sgilmore10 for your help with this pull request!
* GitHub Issue: #41370

Authored-by: Kevin Gurney <kgurney@mathworks.com>
Signed-off-by: Kevin Gurney <kgurney@mathworks.com>
vibhatha pushed a commit to vibhatha/arrow that referenced this pull request May 25, 2024
…f `macos-latest` change to `macos-14` (apache#41384)

### Rationale for this change

* The MATLAB macOS CI workflow is failing because of the recent change to `macos-latest` from `macos-12` to `macos-14`.
* In https://github.blog/changelog/2024-01-30-github-actions-macos-14-sonoma-is-now-available/ it is mentioned that the transition to `macos-14` was planned for April-June 2024.
* As noted in the [Platform Road Map](https://www.mathworks.com/support/requirements/platform-road-map.html), MATLAB R2023a is not officially supported with `macos-14`.
* Until we can move to building against MATLAB R2024a (latest available version of MATLAB), it makes sense to pin back the macOS version to version 14.

### What changes are included in this PR?

1. Pin back MATLAB CI workflow to use `macos-12`.
2. Pin back MATLAB crossbow packaging workflow to use `macos-12`.

### Are these changes tested?

I will run a crossbow job and ensure that the MATLAB CI workflow passes successfully before merging this PR.

### Are there any user-facing changes?

No.

### Future Directions

1.  apache#41385

### Notes

1. Thanks @ sgilmore10 for your help with this pull request!
* GitHub Issue: apache#41370

Authored-by: Kevin Gurney <kgurney@mathworks.com>
Signed-off-by: Kevin Gurney <kgurney@mathworks.com>
CurtHagenlocher pushed a commit to CurtHagenlocher/arrow that referenced this pull request Jun 14, 2024
…f `macos-latest` change to `macos-14` (apache#41384)

### Rationale for this change

* The MATLAB macOS CI workflow is failing because of the recent change to `macos-latest` from `macos-12` to `macos-14`.
* In https://github.blog/changelog/2024-01-30-github-actions-macos-14-sonoma-is-now-available/ it is mentioned that the transition to `macos-14` was planned for April-June 2024.
* As noted in the [Platform Road Map](https://www.mathworks.com/support/requirements/platform-road-map.html), MATLAB R2023a is not officially supported with `macos-14`.
* Until we can move to building against MATLAB R2024a (latest available version of MATLAB), it makes sense to pin back the macOS version to version 14.

### What changes are included in this PR?

1. Pin back MATLAB CI workflow to use `macos-12`.
2. Pin back MATLAB crossbow packaging workflow to use `macos-12`.

### Are these changes tested?

I will run a crossbow job and ensure that the MATLAB CI workflow passes successfully before merging this PR.

### Are there any user-facing changes?

No.

### Future Directions

1.  apache#41385

### Notes

1. Thanks @ sgilmore10 for your help with this pull request!
* GitHub Issue: apache#41370

Authored-by: Kevin Gurney <kgurney@mathworks.com>
Signed-off-by: Kevin Gurney <kgurney@mathworks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants