-
Notifications
You must be signed in to change notification settings - Fork 4k
GH-41370: [CI][MATLAB] MATLAB macOS CI workflow fails because of macos-latest change to macos-14
#41384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…not officially supported on `macos-14` (i.e. `macos-latest`).
…ATLAB R2023a is not officially supported on `macos-14` (i.e. `macos-latest`).
|
All CI workflow checks as passing now that the macOS version is pinned back to I will now submit a crossbow job to verify that the crossbow packaging workflow also works as expected when pinned back to |
|
@github-actions crossbow submit matlab |
|
Revision: cf47c75 Submitted crossbow builds: ursacomputing/crossbow @ actions-019657fd7f
|
|
+1 Looks good! Let's verify the MLTBX file created by the crossbow job works as expected before merging. Thanks! |
|
Crossbow job passed successfully. |
|
+1 |
|
After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 6578c3b. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them. |
…os-latest` change to `macos-14` (#41384) ### Rationale for this change * The MATLAB macOS CI workflow is failing because of the recent change to `macos-latest` from `macos-12` to `macos-14`. * In https://github.blog/changelog/2024-01-30-github-actions-macos-14-sonoma-is-now-available/ it is mentioned that the transition to `macos-14` was planned for April-June 2024. * As noted in the [Platform Road Map](https://www.mathworks.com/support/requirements/platform-road-map.html), MATLAB R2023a is not officially supported with `macos-14`. * Until we can move to building against MATLAB R2024a (latest available version of MATLAB), it makes sense to pin back the macOS version to version 14. ### What changes are included in this PR? 1. Pin back MATLAB CI workflow to use `macos-12`. 2. Pin back MATLAB crossbow packaging workflow to use `macos-12`. ### Are these changes tested? I will run a crossbow job and ensure that the MATLAB CI workflow passes successfully before merging this PR. ### Are there any user-facing changes? No. ### Future Directions 1. #41385 ### Notes 1. Thanks @ sgilmore10 for your help with this pull request! * GitHub Issue: #41370 Authored-by: Kevin Gurney <kgurney@mathworks.com> Signed-off-by: Kevin Gurney <kgurney@mathworks.com>
…f `macos-latest` change to `macos-14` (apache#41384) ### Rationale for this change * The MATLAB macOS CI workflow is failing because of the recent change to `macos-latest` from `macos-12` to `macos-14`. * In https://github.blog/changelog/2024-01-30-github-actions-macos-14-sonoma-is-now-available/ it is mentioned that the transition to `macos-14` was planned for April-June 2024. * As noted in the [Platform Road Map](https://www.mathworks.com/support/requirements/platform-road-map.html), MATLAB R2023a is not officially supported with `macos-14`. * Until we can move to building against MATLAB R2024a (latest available version of MATLAB), it makes sense to pin back the macOS version to version 14. ### What changes are included in this PR? 1. Pin back MATLAB CI workflow to use `macos-12`. 2. Pin back MATLAB crossbow packaging workflow to use `macos-12`. ### Are these changes tested? I will run a crossbow job and ensure that the MATLAB CI workflow passes successfully before merging this PR. ### Are there any user-facing changes? No. ### Future Directions 1. apache#41385 ### Notes 1. Thanks @ sgilmore10 for your help with this pull request! * GitHub Issue: apache#41370 Authored-by: Kevin Gurney <kgurney@mathworks.com> Signed-off-by: Kevin Gurney <kgurney@mathworks.com>
…f `macos-latest` change to `macos-14` (apache#41384) ### Rationale for this change * The MATLAB macOS CI workflow is failing because of the recent change to `macos-latest` from `macos-12` to `macos-14`. * In https://github.blog/changelog/2024-01-30-github-actions-macos-14-sonoma-is-now-available/ it is mentioned that the transition to `macos-14` was planned for April-June 2024. * As noted in the [Platform Road Map](https://www.mathworks.com/support/requirements/platform-road-map.html), MATLAB R2023a is not officially supported with `macos-14`. * Until we can move to building against MATLAB R2024a (latest available version of MATLAB), it makes sense to pin back the macOS version to version 14. ### What changes are included in this PR? 1. Pin back MATLAB CI workflow to use `macos-12`. 2. Pin back MATLAB crossbow packaging workflow to use `macos-12`. ### Are these changes tested? I will run a crossbow job and ensure that the MATLAB CI workflow passes successfully before merging this PR. ### Are there any user-facing changes? No. ### Future Directions 1. apache#41385 ### Notes 1. Thanks @ sgilmore10 for your help with this pull request! * GitHub Issue: apache#41370 Authored-by: Kevin Gurney <kgurney@mathworks.com> Signed-off-by: Kevin Gurney <kgurney@mathworks.com>
Rationale for this change
macos-latestfrommacos-12tomacos-14.macos-14was planned for April-June 2024.macos-14.What changes are included in this PR?
macos-12.macos-12.Are these changes tested?
I will run a crossbow job and ensure that the MATLAB CI workflow passes successfully before merging this PR.
Are there any user-facing changes?
No.
Future Directions
R2024ain CI and crossbow packaging workflows #41385Notes
macos-latestchange tomacos-14#41370