Skip to content

Conversation

@pitrou
Copy link
Member

@pitrou pitrou commented Apr 11, 2019

Also use it for Arrow sublibraries: libarrow_flight.so, libarrow_python.so, libarrow_cuda.so.

@pitrou pitrou force-pushed the ARROW-2796-simply-version-script branch from facf62f to 9fcfc22 Compare April 11, 2019 18:45
Also use it for Arrow sublibraries: libarrow_flight.so, libarrow_python.so, libarrow_cuda.so.
@pitrou pitrou force-pushed the ARROW-2796-simply-version-script branch from 9fcfc22 to c10f994 Compare April 11, 2019 22:09
@codecov-io
Copy link

Codecov Report

Merging #4142 into master will increase coverage by 0.72%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4142      +/-   ##
==========================================
+ Coverage   87.85%   88.57%   +0.72%     
==========================================
  Files         748      613     -135     
  Lines       91841    82177    -9664     
  Branches     1252        0    -1252     
==========================================
- Hits        80683    72790    -7893     
+ Misses      11039     9387    -1652     
+ Partials      119        0     -119
Impacted Files Coverage Δ
cpp/src/arrow/util/thread-pool-test.cc 97.66% <0%> (-0.94%) ⬇️
go/arrow/math/uint64_amd64.go
go/arrow/memory/memory_avx2_amd64.go
js/src/enum.ts
go/arrow/array/builder.go
js/src/Arrow.node.ts
js/src/schema.ts
go/arrow/type_traits_boolean.go
js/src/ipc/node/writer.ts
js/src/visitor/vectorloader.ts
... and 126 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9eaa12f...c10f994. Read the comment docs.

Copy link
Member

@wesm wesm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@wesm wesm closed this in d9f6753 Apr 22, 2019
@pitrou pitrou deleted the ARROW-2796-simply-version-script branch April 22, 2019 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants