GH-41463: [C++] Skip TestConcurrentFillFromScalar for platforms without threading support #41461
Conversation
|
Can we create an issue for this? This is not MINOR and it is currently failing on the 16.1.0 maintenance branch. It should be cherry-picked and for it to be cherry-picked and milestoned correctly we require an issue. |
|
This should not be on 16.1.0, though? |
zanmato1984
changed the title
|
|
|
Or was it added explicitly to 16.1 because of fixing a data race? |
Thanks for reminding. I've filed #41463 and updated the PR description. Sorry for the trouble. |
It was tagged as 16.1.0 and is to was a bug fix to fix the data race I cherry-picked it. Wasn't that expected to be on the release? |
github-actions
bot
added
awaiting committer review
|
@github-actions crossbow submit test-ubuntu-22.04-cpp-emscripten |
|
Revision: bb87a96 Submitted crossbow builds: ursacomputing/crossbow @ actions-8dd2f94f75
|
jorisvandenbossche
removed
the
awaiting committer review
|
Thanks @zanmato1984 for the quick follow-up |
|
After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit 2502915. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 13 possible false positives for unstable benchmarks that are known to sometimes produce them. |
…ut threading support (#41461) ### Rationale for this change See #41463 and #40237 (comment) ### What changes are included in this PR? Skip test for platforms that have no threading support. ### Are these changes tested? Change is test. ### Are there any user-facing changes? None. * GitHub Issue: #41463 Authored-by: Ruoxi Sun <zanmato1984@gmail.com> Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
… without threading support (apache#41461) ### Rationale for this change See apache#41463 and apache#40237 (comment) ### What changes are included in this PR? Skip test for platforms that have no threading support. ### Are these changes tested? Change is test. ### Are there any user-facing changes? None. * GitHub Issue: apache#41463 Authored-by: Ruoxi Sun <zanmato1984@gmail.com> Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
4 participants
Rationale for this change
See #41463 and #40237 (comment)
What changes are included in this PR?
Skip test for platforms that have no threading support.
Are these changes tested?
Change is test.
Are there any user-facing changes?
None.