Skip to content

GH-40944: [Java] Implement TypeEqualsVisitor for StringView #41606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lidavidm merged 1 commit into from
May 12, 2024
Merged

GH-40944: [Java] Implement TypeEqualsVisitor for StringView #41606

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion java/vector/src/main/java/org/apache/arrow/vector/compare/TypeEqualsVisitor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ public Boolean visit(BaseLargeVariableWidthVector left, Void value) {

@Override
public Boolean visit(BaseVariableWidthViewVector left, Void value) {
throw new UnsupportedOperationException("View vectors are not supported.");
return compareField(left.getField(), right.getField());
}

@Override
Expand Down
41 changes: 41 additions & 0 deletions java/vector/src/test/java/org/apache/arrow/vector/compare/TestTypeEqualsVisitor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
import static org.junit.Assert.assertFalse;
import static org.junit.Assert.assertTrue;

import java.nio.charset.StandardCharsets;
import java.util.HashMap;
import java.util.Map;

Expand All @@ -30,6 +31,8 @@
import org.apache.arrow.vector.Float8Vector;
import org.apache.arrow.vector.IntVector;
import org.apache.arrow.vector.VarCharVector;
import org.apache.arrow.vector.ViewVarBinaryVector;
import org.apache.arrow.vector.ViewVarCharVector;
import org.apache.arrow.vector.complex.DenseUnionVector;
import org.apache.arrow.vector.complex.ListVector;
import org.apache.arrow.vector.complex.StructVector;
Expand Down Expand Up @@ -176,4 +179,42 @@ public void testDenseUnionTypeEquals() {
assertFalse(typeVisitor.equals(vector1));
}
}

@Test
public void testStringViewTypeEquals() {
try (final ViewVarCharVector varchar1 = new ViewVarCharVector("varchar1", allocator);
final ViewVarCharVector varchar2 = new ViewVarCharVector("varchar2", allocator);
final ViewVarBinaryVector binary = new ViewVarBinaryVector("binary", allocator)) {
final int valueCount = 2;
final byte[] str0 = "apache".getBytes(StandardCharsets.UTF_8);
final byte[] str1 = "arrow".getBytes(StandardCharsets.UTF_8);

// add elements for varchar1
varchar1.allocateNew(48, valueCount);
varchar1.set(0, str0);
varchar1.set(1, str1);
varchar1.setValueCount(valueCount);

// add elements for varchar2 in a difference order
varchar2.allocateNew(48, valueCount);
varchar2.set(0, str1);
varchar2.set(1, str0);
varchar2.setValueCount(valueCount);

// add elements for binary
binary.allocateNew(48, valueCount);
binary.set(0, str0);
binary.set(1, str1);
binary.setValueCount(valueCount);

// compare ignore check name
TypeEqualsVisitor visitor = new TypeEqualsVisitor(varchar1, /* check name */ false, /* check meta data */ true);
assertTrue(visitor.equals(varchar2));
assertFalse(visitor.equals(binary));

// if we check names, the types should be different
visitor = new TypeEqualsVisitor(varchar1, /* check name */ true, /* check meta data */ true);
assertFalse(visitor.equals(varchar2));
}
}
}