Skip to content

Conversation

@raulcd
Copy link
Member

@raulcd raulcd commented May 20, 2024

Rationale for this change

pygit2 updated how they expose some of the GIT_OBJ variables to use GIT_OBJECT prefix here: libgit2/pygit2@8b3861b

What changes are included in this PR?

Update code to make it compatible with both possible APIs.

Are these changes tested?

Via archery

Are there any user-facing changes?

No

@raulcd raulcd requested review from assignUser and kou as code owners May 20, 2024 16:01
@github-actions
Copy link

⚠️ GitHub issue #41735 has been automatically assigned in GitHub to PR creator.

@raulcd
Copy link
Member Author

raulcd commented May 20, 2024

@github-actions crossbow submit -g python

@github-actions github-actions bot added the awaiting committer review Awaiting committer review label May 20, 2024
@github-actions
Copy link

module 'pygit2' has no attribute 'GIT_OBJ_COMMIT'
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/9161519765

@raulcd
Copy link
Member Author

raulcd commented May 20, 2024

This will fail until it is merged on main.
I've tested on my fork by merging this PR on my main branch and then create a PR to trigger the bot, see:
raulcd#84 (comment)

Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Let's try this!

@kou kou merged commit 11decbc into apache:main May 20, 2024
@kou kou removed the awaiting committer review Awaiting committer review label May 20, 2024
@github-actions github-actions bot added the awaiting merge Awaiting merge label May 20, 2024
@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 11decbc.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 3 possible false positives for unstable benchmarks that are known to sometimes produce them.

vibhatha pushed a commit to vibhatha/arrow that referenced this pull request May 25, 2024
…git2 1.15 API change (apache#41739)

### Rationale for this change

pygit2 updated how they expose some of the `GIT_OBJ` variables to use `GIT_OBJECT` prefix here: libgit2/pygit2@8b3861b

### What changes are included in this PR?

Update code to make it compatible with both possible APIs.

### Are these changes tested?

Via archery

### Are there any user-facing changes?

No
* GitHub Issue: apache#41735

Authored-by: Raúl Cumplido <raulcumplido@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
stevelorddremio pushed a commit to stevelorddremio/arrow that referenced this pull request Jun 17, 2024
…git2 1.15 API change (apache#41739)

### Rationale for this change

pygit2 updated how they expose some of the `GIT_OBJ` variables to use `GIT_OBJECT` prefix here: libgit2/pygit2@8b3861b

### What changes are included in this PR?

Update code to make it compatible with both possible APIs.

### Are these changes tested?

Via archery

### Are there any user-facing changes?

No
* GitHub Issue: apache#41735

Authored-by: Raúl Cumplido <raulcumplido@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
lriggs pushed a commit to lriggs/arrow that referenced this pull request Jun 18, 2024
…git2 1.15 API change (apache#41739)

### Rationale for this change

pygit2 updated how they expose some of the `GIT_OBJ` variables to use `GIT_OBJECT` prefix here: libgit2/pygit2@8b3861b

### What changes are included in this PR?

Update code to make it compatible with both possible APIs.

### Are these changes tested?

Via archery

### Are there any user-facing changes?

No
* GitHub Issue: apache#41735

Authored-by: Raúl Cumplido <raulcumplido@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting merge Awaiting merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants