Skip to content

Conversation

@amoeba
Copy link
Member

@amoeba amoeba commented Jun 13, 2024

Rationale for this change

Fixes #42128.

What changes are included in this PR?

  • Updates to the CentOS 7 and CentOS Stream 8 Dockerfiles we use in the Crossbow packaging job to point to vault.centos.org so they continue to run now that both distros are EOL

Are these changes tested?

Yes, I successfully built both updated Dockerfiles locally.

Are there any user-facing changes?

No.

@kou
Copy link
Member

kou commented Jun 13, 2024

@github-actions crossbow submit centos-*

@github-actions
Copy link

Revision: a9bba3e

Submitted crossbow builds: ursacomputing/crossbow @ actions-3ae3be72c2

Task Status
centos-7-amd64 GitHub Actions
centos-8-stream-amd64 GitHub Actions
centos-8-stream-arm64 GitHub Actions
centos-9-stream-amd64 GitHub Actions
centos-9-stream-arm64 GitHub Actions

@kou kou changed the title GH-42128: [Packaging][CentOS] Migrate Centos 7 and Centos Stream 8 packaging jobs to use vault.centos.org GH-42128: [Packaging][CentOS] Migrate CentOS 7 and CentOS Stream 8 packaging jobs to use vault.centos.org Jun 13, 2024
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also update dev/tasks/linux-packages/apache-arrow-release/yum/centos-{7,8-stream}/Dockerfile?

@github-actions github-actions bot added awaiting review Awaiting review awaiting changes Awaiting changes and removed awaiting review Awaiting review labels Jun 13, 2024
amoeba and others added 2 commits June 12, 2024 20:56
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
…erfile

Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
@github-actions github-actions bot added awaiting review Awaiting review and removed awaiting review Awaiting review awaiting changes Awaiting changes labels Jun 13, 2024
@amoeba
Copy link
Member Author

amoeba commented Jun 13, 2024

@github-actions crossbow submit centos-*

@github-actions
Copy link

Revision: 50da9a9

Submitted crossbow builds: ursacomputing/crossbow @ actions-795dd72b79

Task Status
centos-7-amd64 GitHub Actions
centos-8-stream-amd64 GitHub Actions
centos-8-stream-arm64 GitHub Actions
centos-9-stream-amd64 GitHub Actions
centos-9-stream-arm64 GitHub Actions

@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting review Awaiting review labels Jun 13, 2024
amoeba and others added 4 commits June 12, 2024 21:37
…kerfile

Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
…eam/Dockerfile

Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
…erfile

Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
@github-actions github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Jun 13, 2024
@amoeba
Copy link
Member Author

amoeba commented Jun 13, 2024

@github-actions crossbow submit centos-*

@github-actions
Copy link

Revision: bf74e58

Submitted crossbow builds: ursacomputing/crossbow @ actions-e9c10fdd24

Task Status
centos-7-amd64 GitHub Actions
centos-8-stream-amd64 GitHub Actions
centos-8-stream-arm64 GitHub Actions
centos-9-stream-amd64 GitHub Actions
centos-9-stream-arm64 GitHub Actions

@kou
Copy link
Member

kou commented Jun 13, 2024

It seems that we need the same change in https://github.com/apache/arrow/blob/main/dev/release/verify-yum.sh too.

@kou
Copy link
Member

kou commented Jun 13, 2024

https://github.com/ursacomputing/crossbow/actions/runs/9494341888/job/26164504184#step:11:155

docker run --log-driver none --rm --security-opt seccomp=unconfined --volume /home/runner/work/crossbow/crossbow/arrow:/host:delegated --attach STDOUT --attach STDERR quay.io/centos/centos:stream8 /host/dev/release/verify-yum.sh 17.0.0.dev327 local
Unable to find image 'quay.io/centos/centos:stream8' locally
stream8: Pulling from centos/centos
3ca969c7b6d7: Already exists
Digest: sha256:20da069d4f8126c4517ee563e6e723d4cbe79ff62f6c4597f753478af91a09a3
Status: Downloaded newer image for quay.io/centos/centos:stream8
...
  + dnf install -y --enablerepo=powertools /host/dev/release/../../dev/tasks/linux-packages/yum/repositories/centos/8-stream/x86_64/Packages/apache-arrow-release-17.0.0.dev327-1.el8.noarch.rpm
  CentOS Stream 8 - AppStream                     152  B/s |  38  B     00:00    
  Error: Failed to download metadata for repo 'appstream': Cannot prepare internal mirrorlist: No URLs in mirrorlist

@amoeba
Copy link
Member Author

amoeba commented Jun 13, 2024

@github-actions crossbow submit centos-*

@github-actions
Copy link

Revision: 1d4e70d

Submitted crossbow builds: ursacomputing/crossbow @ actions-4b08fb209c

Task Status
centos-7-amd64 GitHub Actions
centos-8-stream-amd64 GitHub Actions
centos-8-stream-arm64 GitHub Actions
centos-9-stream-amd64 GitHub Actions
centos-9-stream-arm64 GitHub Actions

@amoeba
Copy link
Member Author

amoeba commented Jun 13, 2024

Looks like the crossbow jobs are all going to pass. I pushed one commit after I ran them that shouldn't need re-running. Feel free to suggest tweaks to how I went about the change in verify-yum.sh.

@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting change review Awaiting change review labels Jun 14, 2024
@github-actions github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Jun 14, 2024
@kou
Copy link
Member

kou commented Jun 14, 2024

@github-actions crossbow submit centos-*

@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting change review Awaiting change review labels Jun 14, 2024
@github-actions
Copy link

Revision: 504a36a

Submitted crossbow builds: ursacomputing/crossbow @ actions-4569e9bfdb

Task Status
centos-7-amd64 GitHub Actions
centos-8-stream-amd64 GitHub Actions
centos-8-stream-arm64 GitHub Actions
centos-9-stream-amd64 GitHub Actions
centos-9-stream-arm64 GitHub Actions

@amoeba
Copy link
Member Author

amoeba commented Jun 14, 2024

@github-actions crossbow submit centos-9-*

@github-actions
Copy link

Revision: 504a36a

Submitted crossbow builds: ursacomputing/crossbow @ actions-fe38636a58

Task Status
centos-9-stream-amd64 GitHub Actions
centos-9-stream-arm64 GitHub Actions

@amoeba
Copy link
Member Author

amoeba commented Jun 14, 2024

The second to last run of one of the centos-9-stream jobs failed with an error that made it look like the job got canceled so I re-ran them and everything is passing now.

Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou kou merged commit 69e8a78 into apache:main Jun 14, 2024
@kou kou removed the awaiting changes Awaiting changes label Jun 14, 2024
@github-actions github-actions bot added the awaiting merge Awaiting merge label Jun 14, 2024
@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 69e8a78.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 7 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting merge Awaiting merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Packaging][CentOS] Migrate CentOS 7 and CentOS Stream 8 packaging jobs to use vault.centos.org

2 participants