-
Notifications
You must be signed in to change notification settings - Fork 4k
GH-42222: [Python] Add bindings for CopyTo on RecordBatch and Array classes #42223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jorisvandenbossche
merged 7 commits into
apache:main
from
jorisvandenbossche:gh-42222-copy-to
Aug 21, 2024
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
942184b
GH-42222: [Python] Add bindings for CopyTo on RecordBatch and Array c…
jorisvandenbossche 50f3030
Merge remote-tracking branch 'upstream/main' into gh-42222-copy-to
jorisvandenbossche 6707d8e
Merge remote-tracking branch 'upstream/main' into gh-42222-copy-to
jorisvandenbossche 576d20d
also accept device, expand testing
jorisvandenbossche edfb00f
fix docstring linting
jorisvandenbossche 58ba96a
Merge remote-tracking branch 'upstream/main' into gh-42222-copy-to
jorisvandenbossche 31edba4
fix docstring linting
jorisvandenbossche File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For my curiousity, why did you choose to set the
unwrapwithnogil?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In practice it's what we do for almost all our
unwrapfunctions (and the few that don't use it probably should for consistency)But the reason is 1) that this function does not need to GIL (there is no Python interaction), so it can be marked with
nogil, and 2) actually marking it as such ensures that we can call this method from within awith nogil: ...block (and given that callingunwrap()is typically needed when calling some C++ function, and we typically usewith nogil: ...blocks when we are calling a C++ function, in practice there are quite some cases where we indeed useunwrap()inside such a block)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The first section in this doc really helped me understand when/why to release the gil: https://cython.readthedocs.io/en/latest/src/userguide/nogil.html