Skip to content

ARROW-5269: [C++][Archery] Mark relevant benchmarks as regression #4285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fsaintjacques wants to merge 14 commits into from
Closed

ARROW-5269: [C++][Archery] Mark relevant benchmarks as regression #4285

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
1b5135e
Refactor Builder benchmarks
fsaintjacques May 7, 2019
b7911df
Refactor Bitmap benchmarks
fsaintjacques May 7, 2019
f207974
Refactor CompareFilter benchmarks
fsaintjacques May 8, 2019
bea76ed
Refactor csv benchmarks
fsaintjacques May 9, 2019
a7b4f5f
Improve archery benchmark support
fsaintjacques May 9, 2019
e087647
Refactor JSON benchmarks
fsaintjacques May 9, 2019
ffe723f
Add `benchmark list` sub-command.
fsaintjacques May 21, 2019
908f05a
Change default repetitions to 10 instead of 20
fsaintjacques May 22, 2019
5cebe2c
Normalize benchmarks
fsaintjacques May 22, 2019
8334c68
Remove BM_ benchmark prefix
fsaintjacques May 22, 2019
d8e779a
Reformat
fsaintjacques May 22, 2019
a9ecffd
address comments
fsaintjacques May 28, 2019
4a570ab
Reformat
fsaintjacques May 29, 2019
8378030
Address comments
fsaintjacques May 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions cpp/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,6 +269,9 @@ else()
add_custom_target(all-benchmarks)
add_custom_target(benchmark ctest -L benchmark)
add_dependencies(benchmark all-benchmarks)
if(ARROW_BUILD_BENCHMARKS_REFERENCE)
add_definitions(-DARROW_WITH_BENCHMARKS_REFERENCE)
endif()
endif()

if(NOT ARROW_BUILD_EXAMPLES)
Expand Down
5 changes: 5 additions & 0 deletions cpp/cmake_modules/DefineOptions.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,11 @@ if("${CMAKE_SOURCE_DIR}" STREQUAL "${CMAKE_CURRENT_SOURCE_DIR}")
define_option(ARROW_BUILD_BENCHMARKS "Build the Arrow micro benchmarks, default OFF"
OFF)

# Reference benchmarks are used to compare to naive implementation, or
# discover various hardware limits.
define_option(ARROW_BUILD_BENCHMARKS_REFERENCE
Copy link
Member

@kszucs kszucs May 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really just a nit, but ARROW_WITH_REFERENCE_BENCHMARKS might be a better choice.

Copy link
Member

@pitrou pitrou May 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, there's ARROW_BUILD_BENCHMARKS already. The convention seems to be ARROW_BUILD_xxx to enable the xxx target, and ARROW_WITH_yyy to enable support for the yyy external library.

Copy link
Contributor Author

@fsaintjacques fsaintjacques May 27, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you suggesting changing the s/BUILD/WITH/ or the swap of BENCHMARKS/REFERENCE?

"Build the Arrow micro reference benchmarks, default OFF." OFF)

define_option_string(ARROW_TEST_LINKAGE
"Linkage of Arrow libraries with unit tests executables."
"shared"
Expand Down
Loading