GH-43153: [R] pull on a grouped query returns the wrong column #43172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
Component: R
awaiting committer review
nealrichardson
approved these changes
Jul 7, 2024
Member
nealrichardson
left a comment
nealrichardson
left a comment
There was a problem hiding this comment.
Thanks for catching this
Co-authored-by: Neal Richardson <neal.p.richardson@gmail.com>
github-actions
bot
added
awaiting changes
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit cad13bf. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 21 possible false positives for unstable benchmarks that are known to sometimes produce them. |
38 tasks
jonkeane
added a commit
that referenced
this pull request
Jul 18, 2024
### Rationale for this change Fix a bug in our implementation of `pull` on grouped datasets ### What changes are included in this PR? An additional test, the fix. ### Are these changes tested? Yes, with the test I added to. ### Are there any user-facing changes? Users will now get the expected behavior when using `pull` on grouped queries. **This PR contains a "Critical Fix".** * GitHub Issue: #43153 Lead-authored-by: Jonathan Keane <jkeane@gmail.com> Co-authored-by: Neal Richardson <neal.p.richardson@gmail.com> Signed-off-by: Jonathan Keane <jkeane@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Fix a bug in our implementation of
pullon grouped datasetsWhat changes are included in this PR?
An additional test, the fix.
Are these changes tested?
Yes, with the test I added to.
Are there any user-facing changes?
Users will now get the expected behavior when using
pullon grouped queries.This PR contains a "Critical Fix".
pullon a grouped query returns the wrong column. #43153