Skip to content

Conversation

@danepitkin
Copy link
Member

@danepitkin danepitkin commented Jul 26, 2024

Rationale for this change

  1. Remove maven module references
  2. Fix warning in java-jars job:
Warning:  Some problems were encountered while building the effective model for org.apache.arrow:arrow-bom:pom:18.0.0-SNAPSHOT
Warning:  'parent.relativePath' of POM org.apache.arrow:arrow-bom:18.0.0-SNAPSHOT (/Users/runner/work/crossbow/crossbow/arrow/java/bom/pom.xml) points at org.apache.arrow:arrow-java-root instead of org.apache:apache, please verify your project structure @ line 23, column 11
Warning:  
Warning:  It is highly recommended to fix these problems because they threaten the stability of your build.
Warning:  
Warning:  For this reason, future Maven versions might no longer support building such malformed projects.

What changes are included in this PR?

  • Delete mvn versions:set for removed maven module
  • Add empty relativePath to Arrow BOM, so it doesn't use arrow-java-root

Are these changes tested?

java-jars CI job

Are there any user-facing changes?

No

@danepitkin danepitkin requested a review from lidavidm as a code owner July 26, 2024 15:30
@danepitkin
Copy link
Member Author

@github-actions crossbow submit -g java

@danepitkin danepitkin marked this pull request as draft July 26, 2024 15:30
@github-actions
Copy link

Revision: c5e0d18

Submitted crossbow builds: ursacomputing/crossbow @ actions-1f283d34fe

Task Status
java-jars GitHub Actions
test-conda-python-3.11-spark-master GitHub Actions
verify-rc-source-java-linux-almalinux-8-amd64 GitHub Actions
verify-rc-source-java-linux-conda-latest-amd64 GitHub Actions
verify-rc-source-java-linux-ubuntu-20.04-amd64 GitHub Actions
verify-rc-source-java-linux-ubuntu-22.04-amd64 GitHub Actions
verify-rc-source-java-macos-amd64 GitHub Actions

@danepitkin danepitkin changed the title [Java][Packaging] Add relativePath to Arrow Bom [Java][Packaging] Clean up java-jars job Jul 26, 2024
@danepitkin
Copy link
Member Author

@github-actions crossbow submit java-jars

@github-actions
Copy link

Revision: e468604

Submitted crossbow builds: ursacomputing/crossbow @ actions-cd7ed11f15

Task Status
java-jars GitHub Actions

@danepitkin danepitkin changed the title [Java][Packaging] Clean up java-jars job GH-43432: [Java][Packaging] Clean up java-jars job Jul 26, 2024
@github-actions
Copy link

⚠️ GitHub issue #43432 has been automatically assigned in GitHub to PR creator.

@danepitkin danepitkin marked this pull request as ready for review July 26, 2024 19:45
@danepitkin danepitkin requested a review from vibhatha July 26, 2024 19:59
Copy link
Contributor

@vibhatha vibhatha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @danepitkin. LGTM!

@lidavidm lidavidm merged commit c980ebf into apache:main Jul 29, 2024
@lidavidm lidavidm removed the awaiting committer review Awaiting committer review label Jul 29, 2024
@github-actions github-actions bot added the awaiting merge Awaiting merge label Jul 29, 2024
@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit c980ebf.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them.

pribor pushed a commit to GlobalWebIndex/arrow that referenced this pull request Oct 24, 2025
### Rationale for this change
1) Remove maven module references
2) Fix warning in java-jars job:

```
Warning:  Some problems were encountered while building the effective model for org.apache.arrow:arrow-bom:pom:18.0.0-SNAPSHOT
Warning:  'parent.relativePath' of POM org.apache.arrow:arrow-bom:18.0.0-SNAPSHOT (/Users/runner/work/crossbow/crossbow/arrow/java/bom/pom.xml) points at org.apache.arrow:arrow-java-root instead of org.apache:apache, please verify your project structure @ line 23, column 11
Warning:  
Warning:  It is highly recommended to fix these problems because they threaten the stability of your build.
Warning:  
Warning:  For this reason, future Maven versions might no longer support building such malformed projects.
```

### What changes are included in this PR?

* Delete `mvn versions:set` for removed maven module
* Add empty relativePath to Arrow BOM, so it doesn't use arrow-java-root

### Are these changes tested?

java-jars CI job

### Are there any user-facing changes?

No
* GitHub Issue: apache#43432

Authored-by: Dane Pitkin <dpitkin@apache.org>
Signed-off-by: David Li <li.davidm96@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants