-
Notifications
You must be signed in to change notification settings - Fork 4k
GH-43432: [Java][Packaging] Clean up java-jars job #43431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@github-actions crossbow submit -g java |
|
Revision: c5e0d18 Submitted crossbow builds: ursacomputing/crossbow @ actions-1f283d34fe |
|
@github-actions crossbow submit java-jars |
|
Revision: e468604 Submitted crossbow builds: ursacomputing/crossbow @ actions-cd7ed11f15
|
|
|
vibhatha
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @danepitkin. LGTM!
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit c980ebf. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them. |
### Rationale for this change 1) Remove maven module references 2) Fix warning in java-jars job: ``` Warning: Some problems were encountered while building the effective model for org.apache.arrow:arrow-bom:pom:18.0.0-SNAPSHOT Warning: 'parent.relativePath' of POM org.apache.arrow:arrow-bom:18.0.0-SNAPSHOT (/Users/runner/work/crossbow/crossbow/arrow/java/bom/pom.xml) points at org.apache.arrow:arrow-java-root instead of org.apache:apache, please verify your project structure @ line 23, column 11 Warning: Warning: It is highly recommended to fix these problems because they threaten the stability of your build. Warning: Warning: For this reason, future Maven versions might no longer support building such malformed projects. ``` ### What changes are included in this PR? * Delete `mvn versions:set` for removed maven module * Add empty relativePath to Arrow BOM, so it doesn't use arrow-java-root ### Are these changes tested? java-jars CI job ### Are there any user-facing changes? No * GitHub Issue: apache#43432 Authored-by: Dane Pitkin <dpitkin@apache.org> Signed-off-by: David Li <li.davidm96@gmail.com>
Rationale for this change
What changes are included in this PR?
mvn versions:setfor removed maven moduleAre these changes tested?
java-jars CI job
Are there any user-facing changes?
No