Skip to content

Conversation

@lidavidm
Copy link
Member

@lidavidm lidavidm commented Jul 28, 2024

Rationale for this change

Add the newly ratified extension type.

What changes are included in this PR?

The Go implementation only.

Are these changes tested?

Yes

Are there any user-facing changes?

No.

@lidavidm lidavidm requested a review from zeroshade as a code owner July 28, 2024 23:57
@lidavidm lidavidm marked this pull request as draft July 28, 2024 23:57
@github-actions
Copy link

⚠️ GitHub issue #43455 has been automatically assigned in GitHub to PR creator.

@lidavidm lidavidm linked an issue Jul 29, 2024 that may be closed by this pull request
@lidavidm lidavidm marked this pull request as ready for review July 29, 2024 05:12
@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting committer review Awaiting committer review labels Jul 29, 2024
@lidavidm
Copy link
Member Author

lidavidm commented Aug 2, 2024

rebased + fixed the author before I merge

@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting merge Awaiting merge labels Aug 2, 2024
Co-authored-by: Joel Lubinitsky <33523178+joellubi@users.noreply.github.com>
@github-actions github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Aug 4, 2024
@lidavidm
Copy link
Member Author

lidavidm commented Aug 6, 2024

Any further comments here?

Copy link
Member

@joellubi joellubi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting change review Awaiting change review labels Aug 6, 2024
@zeroshade zeroshade merged commit dea09ec into apache:main Aug 6, 2024
@zeroshade zeroshade removed the awaiting merge Awaiting merge label Aug 6, 2024
@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit dea09ec.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 4 possible false positives for unstable benchmarks that are known to sometimes produce them.

@lidavidm lidavidm deleted the gh-43455 branch August 6, 2024 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Go] Add Opaque canonical extension type

3 participants