-
Notifications
You must be signed in to change notification settings - Fork 4k
GH-43455: [Go] Add Opaque canonical extension type #43459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
|
rebased + fixed the author before I merge |
Co-authored-by: Joel Lubinitsky <33523178+joellubi@users.noreply.github.com>
|
Any further comments here? |
joellubi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit dea09ec. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 4 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Rationale for this change
Add the newly ratified extension type.
What changes are included in this PR?
The Go implementation only.
Are these changes tested?
Yes
Are there any user-facing changes?
No.