Skip to content

Conversation

@lidavidm
Copy link
Member

@lidavidm lidavidm commented Jul 28, 2024

Rationale for this change

Add the newly ratified extension type.

What changes are included in this PR?

The Java implementation only.

Are these changes tested?

Yes

Are there any user-facing changes?

No.

@lidavidm lidavidm linked an issue Jul 28, 2024 that may be closed by this pull request
@github-actions
Copy link

⚠️ GitHub issue #43456 has been automatically assigned in GitHub to PR creator.

@lidavidm lidavidm marked this pull request as ready for review July 29, 2024 05:12
Copy link
Member

@danepitkin danepitkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice work!

Copy link
Contributor

@vibhatha vibhatha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lidavidm, overall LGTM!

@lidavidm lidavidm merged commit f2f3e95 into apache:main Aug 2, 2024
@lidavidm lidavidm removed the awaiting committer review Awaiting committer review label Aug 2, 2024
@lidavidm lidavidm deleted the gh-43456 branch August 2, 2024 00:55
@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit f2f3e95.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 50 possible false positives for unstable benchmarks that are known to sometimes produce them.

pribor pushed a commit to GlobalWebIndex/arrow that referenced this pull request Oct 24, 2025
)

### Rationale for this change

Add the newly ratified extension type.

### What changes are included in this PR?

The Java implementation only.

### Are these changes tested?

Yes

### Are there any user-facing changes?

No.
* GitHub Issue: apache#43456

Authored-by: David Li <li.davidm96@gmail.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Java] Add Opaque canonical extension type

3 participants