Skip to content

GH-43467: [C++] Add support for the official LZ4 CMake package #43468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
assignUser merged 3 commits into from
Jul 31, 2024
Merged

GH-43467: [C++] Add support for the official LZ4 CMake package #43468

assignUser merged 3 commits into from
Jul 31, 2024

Conversation

@kou
Copy link
Member

@kou kou commented Jul 29, 2024 •
edited by github-actions bot
Loading

Rationale for this change

LZ4 1.10.0 provides LZ4::lz4 but LZ4 1.9.4 provides only LZ4::lz4_shared and LZ4::lz4_static. So we need to prepare LZ4::lz4 in our side.

What changes are included in this PR?

Define LZ4::lz4 by LZ4::lz4_shared or LZ4::lz4_static if LZ4::lz4 doesn't exist.

Are these changes tested?

Yes.

Are there any user-facing changes?

Yes.

@kou
apacheGH-43467: [C++] Add support for the official LZ4 CMake package
3f3f175 
LZ4 1.10.0 provides `LZ4::lz4` but LZ4 1.9.4 provides only
`LZ4::lz4_shared` and `LZ4::lz4_static`. So we need to prepare
`LZ4::lz4` in our side.
@kou
Copy link
Member Author

kou commented Jul 29, 2024

@github-actions crossbow submit -g linux

@github-actions
Copy link

github-actions bot commented Jul 29, 2024

⚠️ GitHub issue #43467 has been automatically assigned in GitHub to PR creator.

@github-actions
Copy link

github-actions bot commented Jul 29, 2024

Revision: 3f3f175

Submitted crossbow builds: ursacomputing/crossbow @ actions-0c25fa4488

Task Status
almalinux-8-amd64 GitHub Actions
almalinux-8-arm64 GitHub Actions
almalinux-9-amd64 GitHub Actions
almalinux-9-arm64 GitHub Actions
amazon-linux-2023-amd64 GitHub Actions
amazon-linux-2023-arm64 GitHub Actions
centos-7-amd64 GitHub Actions
centos-8-stream-amd64 GitHub Actions
centos-8-stream-arm64 GitHub Actions
centos-9-stream-amd64 GitHub Actions
centos-9-stream-arm64 GitHub Actions
debian-bookworm-amd64 GitHub Actions
debian-bookworm-arm64 GitHub Actions
debian-trixie-amd64 GitHub Actions
debian-trixie-arm64 GitHub Actions
ubuntu-focal-amd64 GitHub Actions
ubuntu-focal-arm64 GitHub Actions
ubuntu-jammy-amd64 GitHub Actions
ubuntu-jammy-arm64 GitHub Actions
ubuntu-noble-amd64 GitHub Actions
ubuntu-noble-arm64 GitHub Actions

@kou kou mentioned this pull request Jul 31, 2024
Closed
38 tasks
@assignUser
Copy link
Member

assignUser commented Jul 31, 2024 •
edited
Loading

@github-actions crossbow submit r-binary-packages

@kou
Add libxxhash-dev dependency explicitly
90f2b4d 
Because liblz4-dev misses it.
@kou
Copy link
Member Author

kou commented Jul 31, 2024

@github-actions crossbow submit debian-* ubuntu-*

@github-actions
Copy link

github-actions bot commented Jul 31, 2024

Revision: c2c28c8

Submitted crossbow builds: ursacomputing/crossbow @ actions-162465cbc3

Task Status
r-binary-packages GitHub Actions

@github-actions
Copy link

github-actions bot commented Jul 31, 2024

Revision: c2c28c8

Submitted crossbow builds: ursacomputing/crossbow @ actions-033c72d75e

Task Status
debian-bookworm-amd64 GitHub Actions
debian-bookworm-arm64 GitHub Actions
debian-trixie-amd64 GitHub Actions
debian-trixie-arm64 GitHub Actions
ubuntu-focal-amd64 GitHub Actions
ubuntu-focal-arm64 GitHub Actions
ubuntu-jammy-amd64 GitHub Actions
ubuntu-jammy-arm64 GitHub Actions
ubuntu-noble-amd64 GitHub Actions
ubuntu-noble-arm64 GitHub Actions

@kou
Copy link
Member Author

kou commented Jul 31, 2024

+1

@assignUser assignUser merged commit 62fd987 into apache:main Jul 31, 2024
@assignUser assignUser removed the awaiting committer review Awaiting committer review label Jul 31, 2024
@assignUser assignUser mentioned this pull request Jul 31, 2024
Closed
@github-actions github-actions bot added the awaiting committer review Awaiting committer review label Jul 31, 2024
@jonkeane
Copy link
Member

jonkeane commented Jul 31, 2024

Thanks for this! I've been attempting to replicate the CRAN issue locally and this look like it will work (though I haven't yet gotten a full success yet due to other unrelated AWS dependency issues. I'll cherry pick it to our maintenance branch there and test again tomorrow morning

jonkeane pushed a commit that referenced this pull request Jul 31, 2024
@kou @jonkeane
GH-43467: [C++] Add support for the official LZ4 CMake package (#43468)
84386f8 
### Rationale for this change

LZ4 1.10.0 provides `LZ4::lz4` but LZ4 1.9.4 provides only `LZ4::lz4_shared` and `LZ4::lz4_static`. So we need to prepare `LZ4::lz4` in our side.

### What changes are included in this PR?

Define `LZ4::lz4` by `LZ4::lz4_shared` or `LZ4::lz4_static` if `LZ4::lz4` doesn't exist.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

Yes.
* GitHub Issue: #43467

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
@kou kou deleted the cpp-lz4 branch July 31, 2024 05:38
@conbench-apache-arrow
Copy link

conbench-apache-arrow bot commented Jul 31, 2024

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 62fd987.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 82 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@assignUser assignUser assignUser approved these changes

@jonkeane jonkeane Awaiting requested review from jonkeane jonkeane is a code owner

@raulcd raulcd Awaiting requested review from raulcd raulcd is a code owner

Assignees

No one assigned

Labels

awaiting committer review Awaiting committer review Component: C++

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kou @assignUser @jonkeane