Skip to content

Conversation

@kou
Copy link
Member

@kou kou commented Aug 6, 2024

Rationale for this change

= default constructor/deconstructor are needless in arrow::ArrayStatistics.

What changes are included in this PR?

Remove them.

Are these changes tested?

Yes.

Are there any user-facing changes?

No.

@github-actions
Copy link

github-actions bot commented Aug 6, 2024

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

In the case of PARQUET issues on JIRA the title also supports:

PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

See also:

@kou kou changed the title WIP: [C++] Remove redundant default constructor/deconstructor in arrow::ArrayStatistics [C++] Remove redundant default constructor/deconstructor in arrow::ArrayStatistics Aug 6, 2024
@kou kou marked this pull request as draft August 6, 2024 20:11
@kou kou force-pushed the cpp-array-statistics-default branch from 266ea3f to 2226aec Compare August 6, 2024 20:11
@kou kou changed the title [C++] Remove redundant default constructor/deconstructor in arrow::ArrayStatistics GH-43592: [C++] Remove redundant default constructor/deconstructor in arrow::ArrayStatistics Aug 7, 2024
@github-actions
Copy link

github-actions bot commented Aug 7, 2024

⚠️ GitHub issue #43592 has been automatically assigned in GitHub to PR creator.

@kou kou marked this pull request as ready for review August 7, 2024 00:06
@kou
Copy link
Member Author

kou commented Aug 7, 2024

+1

@kou kou merged commit 06f9aee into apache:main Aug 7, 2024
@kou kou deleted the cpp-array-statistics-default branch August 7, 2024 01:22
@kou kou removed the awaiting committer review Awaiting committer review label Aug 7, 2024
@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 06f9aee.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant