Skip to content

Conversation

@nealrichardson
Copy link
Member

@nealrichardson nealrichardson commented Aug 29, 2024

Rationale for this change

The writing-bindings vignette was removed in #41576 (comment). It turns out there were more references to it throughout the docs that I failed to remove

What changes are included in this PR?

Deleting x-refs that don't exist anymore.

Are these changes tested?

Not really

Are there any user-facing changes?

The docs won't point you at links that 404.

@github-actions
Copy link

⚠️ GitHub issue #43665 has been automatically assigned in GitHub to PR creator.

Copy link
Member

@thisisnic thisisnic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching these ones!

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting review Awaiting review labels Sep 1, 2024
@nealrichardson nealrichardson linked an issue Sep 1, 2024 that may be closed by this pull request
@nealrichardson nealrichardson merged commit 1ecfb31 into apache:main Sep 1, 2024
@nealrichardson nealrichardson deleted the remove-doc-link branch September 1, 2024 23:17
@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 1ecfb31.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 9 possible false positives for unstable benchmarks that are known to sometimes produce them.

khwilson pushed a commit to khwilson/arrow that referenced this pull request Sep 14, 2024
)

### Rationale for this change

The writing-bindings vignette was removed in
apache#41576 (comment). It
turns out there were more references to it throughout the docs that I
failed to remove

### What changes are included in this PR?

Deleting x-refs that don't exist anymore.

### Are these changes tested?

Not really

### Are there any user-facing changes?

The docs won't point you at links that 404.
* GitHub Issue: apache#43665
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

R/C++ bindings documentation missing (Error 404)

2 participants