Skip to content

ARROW-5434: [Memory][Java] Introduce wrappers for backward compatibility. #4406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
praveenbingo wants to merge 2 commits into from
Closed

ARROW-5434: [Memory][Java] Introduce wrappers for backward compatibility. #4406

praveenbingo wants to merge 2 commits into from

Conversation

@praveenbingo
Copy link
Contributor

@praveenbingo praveenbingo commented May 29, 2019

  • Introduce some wrapper methods to reduce amount of client changes.
  • Changes were introduced as part of patch to support arrow buffers on random memory.

emkornfield
emkornfield reviewed May 29, 2019
View reviewed changes
java/memory/src/main/java/io/netty/buffer/ArrowBuf.java Outdated
Copy link
Contributor

@emkornfield emkornfield May 29, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we mark these as "@deprecated", so clients know they should moving off of them?

Copy link
Contributor Author

@praveenbingo praveenbingo May 29, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

Copy link
Contributor

@pravindra pravindra May 29, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why deprecate ? It's a useful convenience fn, so also retain.

@emkornfield
Copy link
Contributor

emkornfield commented May 29, 2019

@praveenbingo I think we prefer creating new issues instead of multiple PRs attached to the same issue. Do you mind creating a new one?

@praveenbingo
Copy link
Contributor Author

praveenbingo commented May 29, 2019

@praveenbingo I think we prefer creating new issues instead of multiple PRs attached to the same issue. Do you mind creating a new one?

Sure will do.

@praveenbingo praveenbingo changed the title ARROW-3191: [Memory][Java] Introduce wrappers for backward compatibility. ARROW-5434: [Memory][Java] Introduce wrappers for backward compatibility. May 29, 2019
pravindra
pravindra reviewed May 29, 2019
View reviewed changes
java/memory/src/main/java/io/netty/buffer/ArrowBuf.java Outdated
Copy link
Contributor

@pravindra pravindra May 29, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why deprecate ? It's a useful convenience fn, so also retain.

java/memory/src/main/java/io/netty/buffer/ArrowBuf.java Outdated
Copy link
Contributor

@pravindra pravindra May 29, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree this should be deprecated - readerIndex and writerIndex should move to NettyArrowBuf

Copy link
Contributor Author

@praveenbingo praveenbingo May 29, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ideally we should not have duplicate methods doing the same work, at some point in the future we should remove the older..

@praveenbingo
ARROW-3191: [Memory][Java] Introduce wrappers to keep backward compat…
fdab3dd 
…ibility.

- Introduce some wrapper methods to reduce amount of client changes.
- Changes were introduced as part of patch to support arrow buffers on random memory.
@praveenbingo
Fix review comments and ci.
389c107
@codecov-io
Copy link

codecov-io commented May 29, 2019

Codecov Report

Merging #4406 into master will increase coverage by 1.17%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4406      +/-   ##
==========================================
+ Coverage   88.21%   89.38%   +1.17%     
==========================================
  Files         677      639      -38     
  Lines       78799    88885   +10086     
  Branches     1251        0    -1251     
==========================================
+ Hits        69509    79449    +9940     
- Misses       9054     9436     +382     
+ Partials      236        0     -236
Impacted Files Coverage Δ
cpp/src/plasma/thirdparty/ae/ae.c 70.75% <0%> (-0.48%) ⬇️
go/arrow/ipc/writer.go
go/arrow/math/uint64_amd64.go
go/arrow/memory/memory_avx2_amd64.go
go/arrow/ipc/file_reader.go
js/src/enum.ts
go/arrow/array/builder.go
js/src/Arrow.node.ts
js/src/schema.ts
go/arrow/type_traits_boolean.go
... and 309 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ea7350...389c107. Read the comment docs.

@praveenbingo
Copy link
Contributor Author

praveenbingo commented May 29, 2019 •
edited
Loading

@pravindra can you please merge if this looks ok to you.

@pravindra pravindra closed this in a833444 May 29, 2019
This was referenced May 29, 2019
Closed
Closed
pribor pushed a commit to GlobalWebIndex/arrow that referenced this pull request Oct 24, 2025
@praveenbingo @kou
ARROW-5434: [Memory][Java] Introduce wrappers for backward compatibil…
fb21044 
…ity.

- Introduce some wrapper methods to reduce amount of client changes.
- Changes were introduced as part of patch to support arrow buffers on random memory.

Author: Praveen <praveen@dremio.com>

Closes apache#4406 from praveenbingo/ARROW-3191-1 and squashes the following commits:

389c107 <Praveen> Fix review comments and ci.
fdab3dd <Praveen> ARROW-3191:  Introduce wrappers to keep backward compatibility.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@emkornfield emkornfield emkornfield left review comments

@pravindra pravindra pravindra approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@praveenbingo @emkornfield @codecov-io @pravindra