ARROW-5461: [Java] Add micro-benchmarks for Float8Vector and allocators #4430
Conversation
|
@liyafan82 thank you for doing this. Is there a reason you chose to create a new module instead of adding the benchmarks to the existing sub-projects (memory and vector)? |
Good question. To get reliable and reproducible performance results, JMH is the preferred benchmark framework (as recommended by Jacques Nadeau). And creating a standalone project is the recommended way of doing this. Please see https://openjdk.java.net/projects/code-tools/jmh/
|
emkornfield
left a comment
emkornfield
left a comment
There was a problem hiding this comment.
@liyafan82 can the benchmarks be placed under test instead of main?
Also would it make sense to put them in the same package as the classes they are testing, I think that would make them more discoverable?
| } | ||
|
|
||
| /** | ||
| * Test reading/writing on {@link Float8Vector}. |
There was a problem hiding this comment.
can you give pointers here to the memory bounds check and null check?
There was a problem hiding this comment.
Revised accordingly. Thanks for your good suggestion.
I have moved them to the same packages as their related classes. Thanks for the good suggestion. In addition, I have also placed them as test cases in the test directory. However, I am not sure if this is exactly what you want, since benchmark evaluating can be time consuming. Do you want these benchmarks to be moved to the test directory, and still evaluated by the main method? |
|
Thanks. +1, LGTM |
|
(test failure appears unrelated) |
For the past days, we have been involved in some performance related issues. In this process, we have created some performance benchmarks, to help us verify performance results. Now we want to add such micro-benchmarks to the code base, in the hope that they will be helpful for making performance-related decisions and avoid performance degradation. Author: liyafan82 <fan_li_ya@foxmail.com> Closes apache#4430 from liyafan82/fly_0531_benchmark and squashes the following commits: fde0e0a <liyafan82> Move benchmarks to tests e734b40 <liyafan82> Add micro-benchmarks for Float8Vector and allocators
2 participants
For the past days, we have been involved in some performance related issues. In this process, we have created some performance benchmarks, to help us verify performance results.
Now we want to add such micro-benchmarks to the code base, in the hope that they will be helpful for making performance-related decisions and avoid performance degradation.