Skip to content

ARROW-5464: [Archery] Fix default diff --benchmark-filter #4434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fsaintjacques wants to merge 1 commit into from
Closed

ARROW-5464: [Archery] Fix default diff --benchmark-filter #4434

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions dev/archery/archery/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,11 +158,6 @@ def tmpdir(preserve, prefix="arrow-bench-"):
yield tmp


# Running all benchmarks would be prohibitive. Benchmark who needs to be
# monitored for regression should be named with this prefix.
DEFAULT_BENCHMARK_FILTER = "^Regression"


@archery.group()
@click.pass_context
def benchmark(ctx):
Expand Down Expand Up @@ -283,7 +278,7 @@ def benchmark_run(ctx, src, preserve, suite_filter, benchmark_filter,
@click.option("--suite-filter", metavar="<regex>", show_default=True,
type=str, default=None, help="Regex filtering benchmark suites.")
@click.option("--benchmark-filter", metavar="<regex>", show_default=True,
type=str, default=DEFAULT_BENCHMARK_FILTER,
type=str, default=None,
help="Regex filtering benchmark suites.")
@click.option("--preserve", type=bool, default=False, show_default=True,
is_flag=True, help="Preserve workspace for investigation.")
Expand Down