-
Notifications
You must be signed in to change notification settings - Fork 4k
GH-44393: [C++][Compute] Vector selection functions inverse_permutation and scatter
#44394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
61 commits
Select commit
Hold shift + click to select a range
8de08ae
WIP
zanmato1984 d36330e
WIP
zanmato1984 e68a6d4
Add permute function options
zanmato1984 41bc1cd
WIP
zanmato1984 49f835f
Implementation done and basic tests
zanmato1984 b928c07
Implement permute
zanmato1984 157bc1d
Fix API and doc
zanmato1984 fef6355
Fix API and doc
zanmato1984 9fe37a4
Init docs
zanmato1984 604fa69
Reorg reverse_index
zanmato1984 02914f4
Refine
zanmato1984 5aab878
Update docs
zanmato1984 a21b237
Refine doc
zanmato1984 bdfcf55
Add comments for the implementation
zanmato1984 797bd94
Refine docs
zanmato1984 8946cda
Fix uint64 overflow check
zanmato1984 ee671f2
Reverse indices tests
zanmato1984 b89c4bb
Forbit non-array-like argument
zanmato1984 4a43367
Fix permute option default
zanmato1984 1cc1355
Refine
zanmato1984 04832af
WIP permute tests
zanmato1984 774ccfb
Refine tests
zanmato1984 afd2787
More permute tests
zanmato1984 ea0b0da
Add if-else tests using permute
zanmato1984 338687b
Update some comments
zanmato1984 5519cd1
Fix lint
zanmato1984 bd5ec35
Update comment
zanmato1984 776fe89
Fix typo
zanmato1984 d7a2f61
Typo
zanmato1984 a892bab
Refine
zanmato1984 3df345e
Update cpp/src/arrow/compute/kernels/vector_placement_test.cc
zanmato1984 7108c12
Rename function category to swizzle
zanmato1984 cab0d4c
reverse_indices -> inverse_permutation
zanmato1984 2e6cb70
output_length -> max_index
zanmato1984 e35af38
Permute -> Scatter
zanmato1984 5c22d7c
Fixing some renamings
zanmato1984 ab010f0
Update docs/source/cpp/compute.rst
zanmato1984 84049ac
Update cpp/src/arrow/compute/api_vector.h
zanmato1984 85ed9dc
Update cpp/src/arrow/compute/api_vector.h
zanmato1984 fd03ad7
Update cpp/src/arrow/compute/kernels/vector_swizzle_test.cc
zanmato1984 d9b10cc
Update cpp/src/arrow/compute/kernels/vector_swizzle_test.cc
zanmato1984 ffd2f36
Limit input/output type to signed integers
zanmato1984 acb4fce
Make visit method public and remove friend
zanmato1984 fa1d9f2
Show no mercy to index out of bounds
zanmato1984 4527c47
Use type error instead of invalid
zanmato1984 5419a85
Remove errornous predict false
zanmato1984 a3bd7c3
Avoid uninitialized data buf
zanmato1984 962749b
Coding convention of instantce variables
zanmato1984 ff71d77
Optimize buffer initializing
zanmato1984 6805784
Reduce typed tests
zanmato1984 e30f33c
Naming
zanmato1984 28bfddc
Remove repetition of test cases
zanmato1984 75d96d6
Doc about output length
zanmato1984 0d44639
Fix ci error
zanmato1984 953d3b1
Move new functions into selection category in doc
zanmato1984 b82ad94
Allocate uninitialized buffer and fill the capacity bytes
zanmato1984 eaa9a3c
type -> value_type
zanmato1984 b1f1208
Simplify chunked cases
zanmato1984 4342033
Use common type lists and test for more numeric types
zanmato1984 8e4ecab
Bump `since` version
zanmato1984 6ac321c
Refine function docs
zanmato1984 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.