ARROW-627: [C++] Add compatibility macros for exported extern templates #447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e compiler warnings in MSVC Change-Id: Ib5ca26cbf76c90ae8ae51aeca24e715b77dbf65d
Member
Author
|
This is really weird, Chromium did something similar: https://chromium.googlesource.com/chromium/blink/+/e36bf31fde4c61a79019894eeaa2cfce9ce4014d%5E!/ |
Member
Author
|
I know way more about symbol visibility across platforms than I ever expected |
Member
Author
Change-Id: I461d658667c063bdb6822c517ffd5f6b9ec1032a
Member
Author
|
@Maxris does this look OK to you? |
Member
Author
|
+1, merging this |
wesm
pushed a commit
to wesm/arrow
that referenced
this pull request
Sep 8, 2018
Author: Antoine Pitrou <antoine@python.org> Closes apache#447 from pitrou/ARROW-1974-duplicate-column-name and squashes the following commits: a764a3c [Antoine Pitrou] Pass ColumnIndex() / FieldIndex() node argument by reference 4398d58 [Antoine Pitrou] ARROW-1974: Fix creating Arrow schema with duplicate column names Change-Id: I3b2374610ca33b05e0698656ebc40333e9c85f08
pribor
pushed a commit
to GlobalWebIndex/arrow
that referenced
this pull request
Oct 24, 2025
apache@ded148c was merged after the migration. Fixes apache#447.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should also reduce compiler warnings on MSVC