GH-44974: [Dev] Fix minor issue handling #44975
Conversation
pitrou
requested review from
assignUser,
jonkeane,
kou and
raulcd
as code owners
|
Not sure how to test this before it reaches git main @raulcd |
|
|
There was a problem hiding this comment.
I've tested on my fork.
In order to test it I merge the change on my fork on main and create a PR against my fork, see this PR as an example:
raulcd#86
I had to also apply this change:
raulcd@c297025
otherwise it fails on the Check issue step as seen on this action failure:
https://github.com/raulcd/arrow/actions/runs/12237252551/job/34132570615
with my change applied it is successful as seen here:
https://github.com/raulcd/arrow/actions/runs/12237520289/job/34133461978?pr=86
I've also created a PR with an associated issue with GH- prefix, which is successful and performs the required steps. See here:
https://github.com/raulcd/arrow/actions/runs/12237616405/job/34133767858?pr=88
and the PR: raulcd#88
github-actions
bot
added
awaiting changes
|
This is not going to fix the issue, it still requires this commit to be included: |
|
Oh, sorry. I checked only changes. I should have also checked affected file names. |
### Rationale for this change This is a follow up from: #44975 (comment) ### What changes are included in this PR? Fix the issue_check workflow to not assume all PRs are going to have an associated issue. Fix the worflow for minor issues. ### Are these changes tested? I've tested on my fork. ### Are there any user-facing changes? No Authored-by: Raúl Cumplido <raulcumplido@gmail.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
|
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit f1b293d. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them. |
### Rationale for this change This is a follow up from: apache/arrow#44975 (comment) ### What changes are included in this PR? Fix the issue_check workflow to not assume all PRs are going to have an associated issue. Fix the worflow for minor issues. ### Are these changes tested? I've tested on my fork. ### Are there any user-facing changes? No Authored-by: Raúl Cumplido <raulcumplido@gmail.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
3 participants
Rationale for this change
The current implementation works for
GH-XXXPRs but doesn't work forMINORPRs.What changes are included in this PR?
Add a missing
issue.kindcheck.Are these changes tested?
Yes.
Are there any user-facing changes?
No.