GH-44991: [CI][Python] Fix and modernize AppVeyor build #44999
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pitrou
requested review from
assignUser,
jonkeane,
kou and
raulcd
as code owners
1. Use Mambaforge instead of outdated Miniconda install 2. Install PyArrow using pip, not setup.py Also fixes apacheGH-44997.
pitrou
force-pushed
the
appveyor-pytest-fix
branch
from
915fddf to
178836b
Compare
kou
approved these changes
Dec 12, 2024
Member
kou
left a comment
kou
left a comment
There was a problem hiding this comment.
+1
What causes the DLL load error? Mambaforge? python setup.py develop?
github-actions
bot
added
awaiting merge
Member
Author
|
I think the error disappeared when I switched from AppVeyor's old miniconda install to a miniforge download. But I don't know the underlying reason. |
|
After merging your PR, Conbench analyzed the 2 benchmarking runs that have been run so far on merge-commit 9016a83. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixes GH-44997.
pyarrow.libfails loading on AppVeyor #44991