GH-45135: [C++] Remove useless "hash table ready" states in swiss join #45136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Pretty straightforward cleanup. cc @pitrou @kou @westonpace @mapleFU |
zanmato1984
commented
Dec 31, 2024
| if (!local_states_[thread_index].hash_table_ready) { | ||
| local_states_[thread_index].hash_table_ready = hash_table_ready_.load(); | ||
| } | ||
| ARROW_DCHECK(local_states_[thread_index].hash_table_ready); |
Contributor
Author
There was a problem hiding this comment.
Upper level logic
arrow/cpp/src/arrow/acero/hash_join_node.cc
Line 1039 in 1e45e18
impl_->BuildHashTable and impl_->ProbeSingleBatch) in sequence so we don't actually have to do it all over.
github-actions
bot
added
awaiting committer review
github-actions
bot
added
awaiting merge
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 1df4889. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
See #45135
What changes are included in this PR?
Remove the useless states.
Are these changes tested?
Existing tests suffice.
Are there any user-facing changes?
None.