Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .env
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ KARTOTHEK=latest
# LLVM 12 and GCC 11 reports -Wmismatched-new-delete.
LLVM=14
MAVEN=3.8.7
NODE=18
NODE=20
NUMBA=latest
NUMPY=latest
PANDAS=latest
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/js.yml
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ env:
jobs:

docker:
name: AMD64 Debian 12 NodeJS 18
name: AMD64 Debian 12 NodeJS 20
runs-on: ubuntu-latest
if: ${{ !contains(github.event.pull_request.title, 'WIP') }}
timeout-minutes: 60
Expand Down Expand Up @@ -93,7 +93,7 @@ jobs:
strategy:
fail-fast: false
matrix:
node: [18]
node: [20]
steps:
- name: Checkout Arrow
uses: actions/checkout@v4
Expand Down Expand Up @@ -124,7 +124,7 @@ jobs:
strategy:
fail-fast: false
matrix:
node: [18]
node: [20]
steps:
- name: Checkout Arrow
uses: actions/checkout@v4
Expand Down
14 changes: 5 additions & 9 deletions dev/release/verify-release-candidate.sh
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
# Requirements
# - Ruby >= 2.3
# - gcc >= 4.8
# - Node.js >= 18
# - Node.js >= 20
# - Go >= 1.22
# - Docker
#
Expand Down Expand Up @@ -305,16 +305,12 @@ install_nodejs() {
fi

node_major_version=$(node --version 2>&1 | grep -o '^v[0-9]*' | sed -e 's/^v//g' || :)
node_minor_version=$(node --version 2>&1 | grep -o '^v[0-9]*\.[0-9]*' | sed -e 's/^v[0-9]*\.//g' || :)
if [[ -n "${node_major_version}" && -n "${node_minor_version}" &&
("${node_major_version}" -eq 16 ||
("${node_major_version}" -eq 18 && "${node_minor_version}" -ge 14) ||
"${node_major_version}" -ge 20) ]]; then
show_info "Found NodeJS installation with version v${node_major_version}.${node_minor_version}.x"
if [[ -n "${node_major_version}" && "${node_major_version}" -ge 20 ]]; then
show_info "Found NodeJS installation with version v${node_major_version}.x.x"
else
export NVM_DIR="$(pwd)/.nvm"
mkdir -p $NVM_DIR
curl -sL https://raw.githubusercontent.com/nvm-sh/nvm/v0.39.3/install.sh | \
curl -sL https://raw.githubusercontent.com/nvm-sh/nvm/v0.40.1/install.sh | \
PROFILE=/dev/null bash
[ -s "$NVM_DIR/nvm.sh" ] && \. "$NVM_DIR/nvm.sh"

Expand Down Expand Up @@ -764,7 +760,7 @@ test_js() {
show_header "Build and test JavaScript libraries"

maybe_setup_nodejs
maybe_setup_conda nodejs=18
maybe_setup_conda nodejs=20

if ! command -v yarn &> /dev/null; then
npm install yarn
Expand Down
2 changes: 1 addition & 1 deletion js/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@
"xml2js": "0.6.2"
},
"engines": {
"node": ">=12.0"
"node": ">=20.0"
},
"version": "20.0.0-SNAPSHOT"
}
Loading