Skip to content

Conversation

@zanmato1984
Copy link
Contributor

@zanmato1984 zanmato1984 commented Feb 10, 2025

Rationale for this change

The failure reported in #45393 seems to be caused by a careless parentheses typo introduced in #45336:

reinterpret_cast<uint32_t*>(col_base)[i] = *reinterpret_cast<const uint32_t*>(
rows.fixed_length_rows(start_row + i + offset_within_row));

And unfortunately our Grouper UT doesn't have cases covering this particular code path (the questioning code path is only triggered in Grouper with very restrictive conditions: the row table is fixed-length, a 32-bit key is encoded after some other keys).

What changes are included in this PR?

An UT to reproduce the issue and the fix.

Are these changes tested?

UT included.

Are there any user-facing changes?

None.

@github-actions
Copy link

⚠️ GitHub issue #45393 has been automatically assigned in GitHub to PR creator.

@zanmato1984 zanmato1984 force-pushed the fix-grouper-regression branch from fa43cd6 to 0b81f6e Compare February 10, 2025 04:33
@zanmato1984
Copy link
Contributor Author

@ursabot please benchmark lang=R

@ursabot
Copy link

ursabot commented Feb 10, 2025

Benchmark runs are scheduled for commit 0b81f6e. Watch https://buildkite.com/apache-arrow and https://conbench.ursa.dev for updates. A comment will be posted here when the runs are complete.

@conbench-apache-arrow
Copy link

Thanks for your patience. Conbench analyzed the 3 benchmarking runs that have been run so far on PR commit 0b81f6e.

There were 2 benchmark results indicating a performance regression:

The full Conbench report has more details.

@zanmato1984 zanmato1984 marked this pull request as ready for review February 10, 2025 08:40
@zanmato1984
Copy link
Contributor Author

This should fix the regression/failure of the R benchmarks in our CI. @pitrou would you mind to take a look? Thanks.

And sorry for my careless typo in #45336 that broke CI for such a while. cc @raulcd

@github-actions github-actions bot added awaiting committer review Awaiting committer review and removed awaiting review Awaiting review labels Feb 10, 2025
@zanmato1984
Copy link
Contributor Author

The reported performance regression shouldn't be related. I'm merging this now to get our CI back to green sooner than later.

@zanmato1984 zanmato1984 merged commit d3c4676 into apache:main Feb 10, 2025
39 of 40 checks passed
@zanmato1984 zanmato1984 removed the awaiting committer review Awaiting committer review label Feb 10, 2025
@zanmato1984 zanmato1984 deleted the fix-grouper-regression branch February 10, 2025 08:59
@github-actions github-actions bot added the awaiting committer review Awaiting committer review label Feb 10, 2025
@pitrou
Copy link
Member

pitrou commented Feb 10, 2025

Thanks for the quick fix @zanmato1984 !

@raulcd
Copy link
Member

raulcd commented Feb 10, 2025

Thanks for the fix!

@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit d3c4676.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants