ARROW-510: Integration tests for all date and time combinations #458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
Contributor
|
@wesm is there a Jira for implementing vector container for date and time in Java? |
Member
Author
Change-Id: I79f5d942f64c275c87568703f9edf6a7e89467ac
Change-Id: I94e1708b71a4784545a992166b28543b68f6cfa6
Member
Author
|
Closing since these commits were pulled into #475 |
wesm
pushed a commit
to wesm/arrow
that referenced
this pull request
Sep 8, 2018
…ts when calling helper functions that call ASSERT_ macros There were a number of helper functions in the unit tests that has ASSERT_ macros. However, the callers of these functions were not asserting if the helper functions had encountered an assertion. In those circumstances, the unit test will continue because the ASSERT_ macros only return in the block in which they are used. This commit adds the use of ASSERT_NO_FATAL_FAILURE to the calls of those helper functions at the scope of the unit test, which will cause the unit test to exit. This ensures that we won't encounter segfaults or unexpected behavior due to a unit test continuing execution past an asserting inside of a helper function. Author: Joshua Storck <joshua.storck@twosigma.com> Closes apache#458 from joshuastorck/use_assert_no_fatal_failure and squashes the following commits: fa89f5d [Joshua Storck] There were a number of helper functions in the unit tests that has ASSERT_ macros. However, the callers of these functions were not asserting if the helper functions had encountered an assertion. In those circumstances, the unit test will continue because the ASSERT_ macros only return in the block in which they are used. This commit adds the use of ASSERT_NO_FATAL_FAILURE to the calls of those helper functions at the scope of the unit test, which will cause the unit test to exit. This ensures that we won't encounter segfaults or unexpected behavior due to a unit test continuing execution past an asserting inside of a helper function. Change-Id: Id7a8b0506be0257a9d4fbb2185eae5360f76b65b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As soon as we have the Java support completed, I will rebase and then enable the date/time tests here to get a green build (or find other problems).
I fixed a couple C++ bugs to make integration testing against itself work.