GH-45850: Fix r-devel note about symbols in .a libs #45870
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
awaiting merge
Member
Author
|
I don't see how the dev check failures are related, can I just merge this? @raulcd do you know what's up? |
Member
|
The failures aren't related, they are related to: |
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 629e05f. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 6 possible false positives for unstable benchmarks that are known to sometimes produce them. |
nealrichardson
added a commit
that referenced
this pull request
Mar 28, 2025
### Rationale for this change Suggestion from @gaborcsardi to be more discreet about #45870. ### What changes are included in this PR? `@` ### Are these changes tested? CI should pass ### Are there any user-facing changes? 🤐
amoeba
pushed a commit
that referenced
this pull request
Apr 6, 2025
### Rationale for this change [CRAN](wch/r-source@fb5500b) Fixes #45850 ### What changes are included in this PR? Attempt to delete static libraries we build or download during the R package build. ### Are these changes tested? CI should pass once again ### Are there any user-facing changes? No * GitHub Issue: #45850
amoeba
pushed a commit
that referenced
this pull request
Apr 6, 2025
### Rationale for this change Suggestion from @gaborcsardi to be more discreet about #45870. ### What changes are included in this PR? `@` ### Are these changes tested? CI should pass ### Are there any user-facing changes? 🤐
zanmato1984
pushed a commit
to zanmato1984/arrow
that referenced
this pull request
Apr 15, 2025
### Rationale for this change Suggestion from @gaborcsardi to be more discreet about apache#45870. ### What changes are included in this PR? `@` ### Are these changes tested? CI should pass ### Are there any user-facing changes? 🤐
35 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
CRAN
Fixes #45850
What changes are included in this PR?
Attempt to delete static libraries we build or download during the R package build.
Are these changes tested?
CI should pass once again
Are there any user-facing changes?
No
rhub/ubuntu-gcc12:latestis failing due to warnings on libarrow_bundled_dependencies.a #45850