GH-45959: [C++][CMake] Fix Protobuf dependency in Arrow::arrow_static #45960
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…static If Protobuf is used only for Flight, Arrow::arrow_static must not depend on Protobuf. Instead, ArrowFlight::arrow_flight_static must depend on Protobuf.
Member
Author
|
@github-actions crossbow submit -g cpp |
|
|
Member
Author
|
@anku94 Could you try this? |
github-actions
bot
added
Component: C++
Component: FlightRPC
awaiting committer review
|
Revision: e778459 Submitted crossbow builds: ursacomputing/crossbow @ actions-17b26eac16
|
lidavidm
approved these changes
Mar 28, 2025
github-actions
bot
added
awaiting merge
raulcd
approved these changes
Mar 28, 2025
Member
|
The appveyor failure is unrelated (it also happens on main). I've opened: |
|
After merging your PR, Conbench analyzed the 0 benchmarking runs that have been run so far on merge-commit 3c63f37. None of the specified runs were found on the Conbench server. The full Conbench report has more details. |
zanmato1984
pushed a commit
to zanmato1984/arrow
that referenced
this pull request
Apr 15, 2025
…static (apache#45960) ### Rationale for this change If Protobuf is used only for Flight, Arrow::arrow_static must not depend on Protobuf. Instead, ArrowFlight::arrow_flight_static must depend on Protobuf. ### What changes are included in this PR? Use `ARROW_PROTOBUF_ARROW_CMAKE_PACKAGE_NAME` instead of `ARROW_WITH_PROTOBUF` to detect which CMake target must depend on Protobuf. ### Are these changes tested? Yes. ### Are there any user-facing changes? Yes. * GitHub Issue: apache#45959 Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
If Protobuf is used only for Flight, Arrow::arrow_static must not depend on Protobuf. Instead, ArrowFlight::arrow_flight_static must depend on Protobuf.
What changes are included in this PR?
Use
ARROW_PROTOBUF_ARROW_CMAKE_PACKAGE_NAMEinstead ofARROW_WITH_PROTOBUFto detect which CMake target must depend on Protobuf.Are these changes tested?
Yes.
Are there any user-facing changes?
Yes.