-
Notifications
You must be signed in to change notification settings - Fork 4k
GH-46025: [C++] Use ARROW_CUDA_EXPORT instead of ARROW_EXPORT for libarrow_cuda #46030
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@github-actions crossbow submit -g cuda |
|
Revision: 6a791cba771fa311205131724356a54a4307ae5e Submitted crossbow builds: ursacomputing/crossbow @ actions-93a53001c3
|
kou
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
But could you merge this after #46006 is merged and add Cflags.private: -DARROW_CUDA_STATIC to arrow-cuda.pc.in?
Related changes for adding Cflags.private: -DARROW_CUDA_STATIC to arrow-cuda.pc.in:
|
I'll wait until we merge #46006 (and rebase) to add the other relevant CMake changes, and will update |
…nking even when only libarrow_cida.a is being built
|
@github-actions crossbow submit -g cuda |
|
Revision: 9aa1470 Submitted crossbow builds: ursacomputing/crossbow @ actions-2bef8745df
|
|
@kou this should be ready for re-review |
kou
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 770eaf4. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 3 possible false positives for unstable benchmarks that are known to sometimes produce them. |
…or libarrow_cuda (apache#46030) ### Rationale for this change The code under `arrow/gpu/` isn't included in `libarrow.dll`. We need to use different `*_EXPORT` macros for separated DLL. ### What changes are included in this PR? Create a new `ARROW_CUDA_EXPORT` macro to export cuda symbols. ### Are these changes tested? No new tests but should be tested via the cuda archery jobs. ### Are there any user-facing changes? No * GitHub Issue: apache#46025 Authored-by: Raúl Cumplido <raulcumplido@gmail.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Rationale for this change
The code under
arrow/gpu/isn't included inlibarrow.dll. We need to use different*_EXPORTmacros for separated DLL.What changes are included in this PR?
Create a new
ARROW_CUDA_EXPORTmacro to export cuda symbols.Are these changes tested?
No new tests but should be tested via the cuda archery jobs.
Are there any user-facing changes?
No
arrow/gpu/should not reuseARROW_EXPORT#46025