Skip to content

Conversation

@fsaintjacques
Copy link
Contributor

libarrow_testing and libarrow_flight_testing should not be installed.
Also fix the unit tests with LD_LIBRARY_PATH due to install target and
cmake handling of RPATH.

ARROW_TEST_*_LINK_LIBS is already included via the add_arrow_test
function.
libarrow_testing and libarrow_flight_testing should not be installed.
Also fix the unit tests with LD_LIBRARY_PATH due to install target and
cmake handling of RPATH.
@wesm
Copy link
Member

wesm commented Jun 20, 2019

@ursabot crossbow test docker

@ursabot
Copy link

ursabot commented Jun 20, 2019

AMD64 Conda Crossbow (#22682) builder has been succeeded.

Revision: 10f4e1f

Submitted crossbow builds: ursa-labs/crossbow @ ursabot-31

Task Status
docker-python-3.6-alpine Build Status
docker-python-3.7 Build Status
docker-turbodbc-integration Build Status
docker-python-2.7-alpine Build Status
docker-spark-integration Build Status
docker-cpp Build Status
docker-cpp-alpine Build Status
docker-python-3.6-nopandas Build Status
docker-pandas-master Build Status
docker-c_glib Build Status
docker-r Build Status
docker-hdfs-integration Build Status
docker-dask-integration Build Status
docker-js Build Status
docker-clang-format Build Status
docker-rust Build Status
docker-iwyu Build Status
docker-cpp-cmake32 Build Status
docker-go Build Status
docker-python-2.7 Build Status
docker-docs Build Status
docker-python-2.7-nopandas Build Status
docker-python-3.6 Build Status
docker-lint Build Status
docker-java Build Status

@fsaintjacques fsaintjacques changed the title ARROW-5633: [C++] Ensure testing libraries are not installed ARROW-5653: [C++] Ensure testing libraries are not installed Jun 20, 2019
@wesm
Copy link
Member

wesm commented Jun 21, 2019

Looks like macOS is setting the install rpath in the executables

 2/65 Test  #2: plasma-client_tests ................***Failed    0.52 sec
Running plasma-client_tests, redirecting output into /Users/travis/build/apache/arrow/cpp-build/build/test-logs/plasma-client_tests.txt (attempt 1/1)
dyld: Library not loaded: /Users/travis/build/apache/arrow/cpp-install/lib/libarrow_testing.14.dylib
  Referenced from: /Users/travis/build/apache/arrow/cpp-build/debug/plasma-client_tests
  Reason: image not found
/Users/travis/build/apache/arrow/cpp/build-support/run-test.sh: line 97: 11021 Abort trap: 6           $TEST_EXECUTABLE "$@" 2>&1
     11022 Done                    | $ROOT/build-support/asan_symbolize.py
     11024 Done                    | ${CXXFILT:-c++filt}
     11026 Done                    | $ROOT/build-support/stacktrace_addr2line.pl $TEST_EXECUTABLE
     11028 Done                    | $pipe_cmd 2>&1
     11030 Done                    | tee $LOGFILE
~/build/apache/arrow/cpp-build/src/plasma

@fsaintjacques
Copy link
Contributor Author

I'll close this in favor of #4605

@StefanBruens
Copy link

Why was this closed? libarrow_testing.{so,a} is still installed, dito the header files.

@wesm
Copy link
Member

wesm commented Aug 6, 2022

Can you please open a Jira issue? To make sure this is fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants